Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all messages formatted properly #1

Closed
sumerman opened this issue Apr 15, 2016 · 2 comments
Closed

Not all messages formatted properly #1

sumerman opened this issue Apr 15, 2016 · 2 comments

Comments

@sumerman
Copy link

Keep getting this in my logs:

FORMAT ERROR: "~s" [[<<"GenServer :redis_sub_0_8 terminating">>,<<"\n** (stop) ">>|<<":redis_down">>]

I guess you either have to change ~s to ~p, or (probably better) apply iolist_to_binary to the message

@jonathanperret
Copy link
Owner

Hi @sumerman, I got that too at first. At first I thought I would have to apply iolist_to_binary (or the Elixir wrapper, IO.iodata_to_binary), but that would be introducing another inefficiency into something that is already not very efficient. ~p would not do because it would quote everything.

Turns out it's actually a recently fixed problem in lager: /~https://github.com/basho/lager/issues/326 so on my projects I just upgraded lager to the latest (3.2.0 includes the fix).

Do you think this would still be worth a mention in the README ?

@sumerman
Copy link
Author

Thanks for the explanation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants