Regression from #2131

[tarkah]

Related to #2131

This change seems to break when you have thousands separator AND decimal separator...

source from amazon id="priceblock_ourprice": $1,799.00

replace = $1,799.00 (doesn't actually do anything?)
match = ["1", "799", 00")
join = 1.799.00
parseFloat = 1.799

Also, the regex shouldn't be "escaped" here. It's actually doing nothing (matching on literal \ and . or literal \ and ,. However, even if it was replacing correctly, the number would parse as 179900 which is also incorrect.

Originally posted by @tarkah in #2131 (comment)

[starcraft66]

I think I just ran into this issue. The latest nightly of streetmerchant is telling me that this card is selling for $2.498 when it is in fact for sale for $2,498.99 on the website.

[tarkah]

#2153 has a fix. However, I feel like the old way of defining the price in the model as "euro" and having much simpler logic that we know will work, was the better solution. There is still a "hack" in #2153 that is sane, but will still potentially miss things.

[jef]

Agreed @tarkah. I might revert if it continues to cause problems. I'll close this for now and reopen if we see this becoming a problem.

[jef]

I ended up reverting everything, didn't want to hold this off much longer. We can revisit this when I have more time to test.

That being said, I have mocha and sinon as dev dependencies. Something like this in the future should really have testing around it.

Refs: 0ff8158, 91c4f12