Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Search functionality does not work #224

Closed
jjimenezshaw opened this issue Oct 27, 2023 · 8 comments
Closed

Doc: Search functionality does not work #224

jjimenezshaw opened this issue Oct 27, 2023 · 8 comments
Assignees

Comments

@jjimenezshaw
Copy link

In the documentation in readthedocs, the Search functionality does not return anything. It stays "Searching..." forever.

https://python-geojson.readthedocs.io/en/latest/search.html?q=point&check_keywords=yes&area=default

@jjimenezshaw
Copy link
Author

jjimenezshaw commented Oct 27, 2023

@mwtoews that happened also during the migration to readthedocs in PROJ. Do you remember what happened?

@mwtoews
Copy link

mwtoews commented Oct 27, 2023

The fix was from OSGeo/PROJ@fd1b61e

But I don't even see how this can be done for this repo. Also, the docs for this repo is only one page, so if anything the search should be disabled.

@jjimenezshaw
Copy link
Author

Thanks!

Search is the most noticeable thing, but there are other controls that do not work, like the version selector in the bottom left part "v: latest", or the whole menu button (burger button) when using it in a mobile device.

@mwtoews
Copy link

mwtoews commented Oct 27, 2023

Yeah, I noticed the non-working controls too, which was the same as from the broken PROJ docs too. It's probably missing sphinxcontrib.jquery from the extensions list.

@rayrrr
Copy link
Member

rayrrr commented Nov 22, 2023

@mwtoews et al., thanks for reporting this issue and providing some tips. I'm looking into it now.

@blaisep
Copy link

blaisep commented May 28, 2024

jazzband/help#349 (comment)
@mwtoews , @jjimenezshaw

these files are missing in master:
OSGeo/PROJ@fd1b61e#diff-b958e0b3bc83edf72c782356993bf399fe683350ec85f2a59d2b5c03d3930d38

we need them , or something similar,
we also need a .readthedocs.yaml that looks something like this:

# .readthedocs.yaml
# Read the Docs configuration file
# See https://docs.readthedocs.io/en/stable/config-file/v2.html for details

version: 2

build:
  os: ubuntu-22.04
  tools:
    python: "3.10"

sphinx:
  configuration: docs/source/conf.py

python:
  install:
  - requirements: requirements.txt
  - method: pip
    path: .

@blaisep blaisep self-assigned this May 28, 2024
@rayrrr rayrrr mentioned this issue Aug 7, 2024
@rayrrr
Copy link
Member

rayrrr commented Aug 7, 2024

The above-mentioned PR, #227, is an attempt to fix this issue based on the above discussion. @blaisep and/or @mwtoews would you be kind enough to give it a review?

Basically, I used sphinx-quickstart to get a foundation, and then made some tweaks based on your recommendations.

@rayrrr
Copy link
Member

rayrrr commented Aug 10, 2024

@blaisep et al., I went ahead and merged the fix for this without review since it didn't touch any package functionality, and the issue is now resolved. Thanks for reporting it @jjimenezshaw.

@rayrrr rayrrr closed this as completed Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants