Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address Regex Memory Bloat in Long Running Applications #36

Closed
iwillspeak opened this issue Jan 1, 2019 · 2 comments · Fixed by iwillspeak/IronRure-Batteries#18 or #39
Closed

Address Regex Memory Bloat in Long Running Applications #36

iwillspeak opened this issue Jan 1, 2019 · 2 comments · Fixed by iwillspeak/IronRure-Batteries#18 or #39
Labels
Feature Enhancements and feature requests

Comments

@iwillspeak
Copy link
Owner

iwillspeak commented Jan 1, 2019 •
edited
Loading

Thread-local scratch space is only clearered when the regex is disposed. If regexes are used on the threadpool you can end up with quite a lot of memory usage quite quickly.

We could solve this by exposing the ability to clone the regex for each match.
@iwillspeak iwillspeak added the Feature Enhancements and feature requests label Jan 2, 2019
@iwillspeak
Copy link
Owner Author

This is going to need a clone function adding to the regex batteries crate and exposing for FFI.

@iwillspeak iwillspeak mentioned this issue Jan 6, 2019
Closed
@iwillspeak
Copy link
Owner Author

Cloning might not be required given the fix upstream in rust-lang/regex#362. Addressing that with iwillspeak/IronRure-Batteries#18.

@iwillspeak iwillspeak mentioned this issue Jun 8, 2021
Merged
@iwillspeak iwillspeak changed the title Add Clone to Regex to Combat Memory Bloat Address Regex Memory Bloat in Long Running Applications Jun 8, 2021
@iwillspeak iwillspeak reopened this Jun 9, 2021
@iwillspeak iwillspeak mentioned this issue Jun 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Enhancements and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump Regex Crate Version iwillspeak/IronRure-Batteries
Bump Batteries iwillspeak/IronRure
1 participant
@iwillspeak