Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document iCub 3 joint limits #174

Closed
pattacini opened this issue Sep 9, 2021 · 3 comments
Closed

Document iCub 3 joint limits #174

pattacini opened this issue Sep 9, 2021 · 3 comments

Comments

@pattacini
Copy link
Member

See robotology/icub-models-generator#202 (comment).

cc @traversaro

@traversaro
Copy link
Member

The documentation in https://icub-tech-iit.github.io/documentation/icub3/icub3-joints/ (generated from /~https://github.com/icub-tech-iit/documentation/blob/a828191b77c30df153c9dcb2156b1d8cce9ec9a0/docs/icub3/icub3-joints.md) has some information on hardware limits, while software limits are missing from several joints. Documenting hardware and software limits is important as this information is encoded in several different points of the software infrastructure, including:

I could have missed some other points in which limits information is hardcoded, but even just those one highlight the importance of clearly documenting this limits. In general, as a starting point we can simply just take the values that are present in these configuration files and add them to the documentation. If those values are wrong, we can always change them later.

There are already some values that are clearly inconsistent. For example, for the shoulder roll we had a discussion in robotology/icub-models-generator#202 (comment) that the software upper limit is 163, but the documentation at the moment reports that the hardware upper limit is 150, see /~https://github.com/icub-tech-iit/documentation/blame/1ddb4dee540033d3ff10a48c5ab388d618e5021e/docs/icub3/icub3-joints.md#L125 so probably also limits already present in the document may need to be reviewed.

@traversaro
Copy link
Member

Example of issue in which this would be useful: robotology/icub-models#104 (comment) .

@pattacini
Copy link
Member Author

Same as #175 (comment).

cc @traversaro

@pattacini pattacini closed this as not planned Won't fix, can't repro, duplicate, stale Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants