Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

structlog.get_context breaks from 23.2.0 to 23.3.0 #585

Closed
val-melev opened this issue Jan 3, 2024 · 1 comment
Closed

structlog.get_context breaks from 23.2.0 to 23.3.0 #585

val-melev opened this issue Jan 3, 2024 · 1 comment

Comments

@val-melev
Copy link

in version 23.2.0 we get

$ logger = get_logger(context="a")  
$ get_context(logger)  
{'context': 'a'}

in version 23.3.0 we get

$ logger = get_logger(context="a")  
$ get_context(logger)  
{}

is it wrong to assume stability for get_context? Doesn't seem like it'd be internal function. It's also not mentioned in the changelog.

@hynek
Copy link
Owner

hynek commented Jan 3, 2024

hrhm side-effect of #561 – hope it's the only one.

fixed by 813bc14

@hynek hynek closed this as completed Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants