Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not support links with 302 redirect #1064

Closed
chameleonTK opened this issue Dec 3, 2020 · 2 comments
Closed

Not support links with 302 redirect #1064

chameleonTK opened this issue Dec 3, 2020 · 2 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@chameleonTK
Copy link
Contributor

I have an issue adding this download link /~https://github.com/jitkapat/thailitcorpus/releases/download/v.2.0/tlc_v.2.0.tar.gz

it might be because it is not a direct link (it returns 302 and redirects to aws that returns 403 for head requests).

r.head("/~https://github.com/jitkapat/thailitcorpus/releases/download/v.2.0/tlc_v.2.0.tar.gz", allow_redirects=True)                                      
# <Response [403]>
@SBrandeis SBrandeis added enhancement New feature or request bug Something isn't working labels Dec 18, 2020
@lhoestq
Copy link
Member

lhoestq commented Jan 13, 2021

Hi !
This kind of links is now supported by the library since #1316

@chameleonTK chameleonTK mentioned this issue Jan 14, 2021
Merged
@chameleonTK
Copy link
Contributor Author

Hi !
This kind of links is now supported by the library since #1316

I updated links in TLC datasets to be the github links in this pull request
#1737

Everything works now. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chameleonTK @SBrandeis @lhoestq