-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Entities visualization with Mermaid.js #38
Comments
Just to give some example about what we can explore, I would like to share this link that Dalsoft shared with me we have many diagrams opportunity to explore with this feature |
why did you reopen it? |
well, not really. the initial idea was to have this diagrams inside Shelf UI with diagrams auto generated by Herbs metadata. The PR above only allows to Mermaid diagrams to be part of the README file, created manually (which is completely fine). |
@dalssoft is right. I reopened it because is not totally closed yet. |
Hi guys! I will work on this issue! |
@maikmb ideally we could have a more in-depth discussion on how to document the entities, but thinking about it, I believe your suggestion would work well for a first version |
Thanks @dalssoft! We will implement the first version and improve it later. |
Hi @jhomarolo! |
Looks great. We should test it in a big project and see how it behaves. |
@maikvortx I think is missing the pointer showing the relation 1 ... N Inside the diagram should be But, anyhow, looks amazing! This is a huge feature |
Related: #24 |
Hi everyone! |
@maikvortx, It's becoming excellent! I have only two considerations: 1 - About the ordering of the diagram. Is there any way to sort the diagram automatically? It seemed to me that the diagram gets a little confusing in a big system 2 - I believe that mine needs to include use cases and entities. That is, create a folder called use cases and leave them there. From the way you sent the print, it implies that the entities link is also a use case Does it make sense to you? I think we're almost there on this PR! |
@maikmb amazing work! this is going to be a killer feature! I agree with @jhomarolo on (1): i think we should find a way to implement a diagram reorder. ideally having a button where the user can choose which reorder they want. regarding (2) (to include use cases and entities), i think it is a improvement we can discuss, but for now I would leave without UCs. |
Hey guys! I agree with you. (1) What do think about implementing diagram reorder in another PR? I will study Mermaid to implement this feature. In a big project, the class diagram gets a little confusing. |
"de bate pronto", is there a any indication of Mermaid having this feature? It doesn't seem like it mermaid-js/mermaid#806 |
We could use groups metadata to entities like we have in use cases. This way we could create sub-views to view entities so we don´t have to show the whole thing... yes, I know, it is another issue, but just to document it |
It's a good idea @dalssoft. I can implement it in another PR. |
Great!!! But in order to have groups shown, it must be informed as metadata: module.exports =
herbarium.entities
.add(List, 'List')
.metadata({ group: 'Core Entities' })
.entity |
implement entities doc with mermaid class diagran to herbsshelf BREAKING CHANGE: include a new paramter to renderShefHtml method re herbsjs#38
…doc description ref herbsjs#38
# [4.0.0](v3.2.0...v4.0.0) (2022-07-13) ### Features * **mermaid-entities:** centralize class diagram and change entities doc description ([cb24e66](cb24e66)), closes [#38](#38) * **mermaid-entities:** implement entities doc with mermaid ([0eb7d15](0eb7d15)), closes [#38](#38) ### BREAKING CHANGES * **mermaid-entities:** include a new paramter to renderShefHtml method
It would be interesting to understand a entity and its relationships not only in code but also having a more "visual" approach and have this information as part of Shelf experience.
For that we could extract metadata from Herbs
entity
and export to MermaidJS:The text was updated successfully, but these errors were encountered: