Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snapPoints it differs a lot between operating systems #77

Closed
Angelk90 opened this issue Nov 20, 2020 · 1 comment · Fixed by #81
Closed

snapPoints it differs a lot between operating systems #77

Angelk90 opened this issue Nov 20, 2020 · 1 comment · Fixed by #81
Labels
bug Something isn't working

Comments

@Angelk90
Copy link

Bug

90%
Schermata 2020-11-20 alle 22 24 05

100%

Schermata 2020-11-20 alle 22 30 53

Hi @gorhom ,

I am using your component on different devices, I tried to put snapPoints = "90%".
I noticed that it differs a lot between the two, as can be seen from the image.

I tried with higher values (100%), it seems that on android it works fine but on ios it gives problems, it goes further.

Environment info

Library Version
@gorhom/bottom-sheet 1.4.1
react-native 0.63.3
react-native-reanimated 1.13.2
react-native-gesture-handler 1.8.0

Reproducible sample code

{
          snapPoints: ['90%'],
          animationDuration: 10,
          overlayComponent: BottomSheetOverlay,
          overlayOpacity: 0.5,
          dismissOnOverlayPress: true,
        }
@Angelk90 Angelk90 added the bug Something isn't working label Nov 20, 2020
@gorhom
Copy link
Owner

gorhom commented Nov 20, 2020

hi @Angelk90 , thanks for reporting this bug, i am well aware of it and currently working on a fix 👍

@gorhom gorhom linked a pull request Nov 22, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants