Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update google-cloud-bigquery to use bigquery_magics package #14

Closed
2 tasks done
tswast opened this issue Apr 11, 2024 · 1 comment · Fixed by googleapis/python-bigquery#1965
Closed
2 tasks done
Assignees
Labels
api: bigquery Issues related to the googleapis/python-bigquery-magics API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@tswast
Copy link
Collaborator

tswast commented Apr 11, 2024

The code in /~https://github.com/googleapis/python-bigquery/tree/main/google/cloud/bigquery/magics is redundant with this module. After our first release, delete that code and update google-cloud-bigquery to be backwards-compatible.

Sub-tasks:

  • Update google.cloud.bigquery.load_ipython_extension to load the bigquery_magics extension instead. Raise an exception warning prompting the user to install bigquery_magics if not installed.
  • [N/A] Remove /~https://github.com/googleapis/python-bigquery/tree/main/google/cloud/bigquery/magics except for google.cloud.bigquery.magics.context and google.cloud.bigquery.magics.magics.context, which will be aliases to the bigquery_magics.context object. Edit: keeping this code intact for now, but deprecating it. To be removed in a future version of google-cloud-bigquery.
  • [N/A] Update unit/system tests to be minimal to verify that we're calling out to bigquery_magics now. keeping this code intact for now, but deprecating it. To be removed in a future version of google-cloud-bigquery.
  • Update the magics-related "extras" in google-cloud-bigquery's setup.py to just depend on bigquery_magics.
@tswast tswast added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Apr 11, 2024
@tswast tswast self-assigned this Apr 11, 2024
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-magics API. label Apr 11, 2024
@tswast
Copy link
Collaborator Author

tswast commented Jul 8, 2024

googleapis/python-bigquery#1965 covers this issue. Note: it doesn't fully remove the google.cloud.bigquery.magics module, just deprecates it and updates to use this package when available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-magics API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant