View metrics CTA on notifications should not add new metrics

[wpdarren]

Bug Description

When replicating the scenario from this issue Can view metrics appear a second time? - setting up tailored metrics with Publish blog purpose, and then detecting add_to_cart as new event (detected events - contact, add_to_cart, new detected events - add_to_cart), view metrics CTA should open a selection panel instead of adding new metrics.

Steps to reproduce

• Setup Site Kit with tailored metrics - use Publish blog as a site purpose with no events detected
• Force purchase event as detected and new detected event
• When notification shows with View metrics CTA, click on it
• Verify that it adds metrics, acting like Add metrics CTA variation

From @zutigrm

Quick reminder for myself when opening the issue for this - useDisplayNewEventsCalloutForTailoredMetrics hook, when calling haveConversionEventsForTailoredMetrics pass true as a parameter

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• When new metrics are detected, not matching the current site purpose - View Metrics CTA should always open a selection panel

Implementation Brief

• In assets/js/components/KeyMetrics/hooks/useDisplayNewEventsCalloutForTailoredMetrics.js
  • Pass true as an argument to the hook

    site-kit-wp/assets/js/components/KeyMetrics/hooks/useDisplayNewEventsCalloutForTailoredMetrics.js

    Line 54 in fe067d8

    ).haveConversionEventsForTailoredMetrics();

Test Coverage

• No updates are needed

QA Brief

Changelog entry

[eugene-manuilov]

IB ✔