"Top traffic source driving leads" showing empty data for 90 days

[wpdarren]

Bug Description

The "Top traffic source driving leads" is unexpectedly showing empty data for the 90 day range:

It's showing data as expected for e.g. 28 days:

Note that there was a row of data returned in my validation report for the 90 day range:

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• Top traffic source driving leads key metrics widget should return correct data for date ranges

Implementation Brief

• In assets/js/modules/analytics-4/components/widgets/TopTrafficSourceDrivingLeadsWidget.js
  • Update existing function

    site-kit-wp/assets/js/modules/analytics-4/components/widgets/TopTrafficSourceDrivingLeadsWidget.js

    Line 48 in 842d751

    function getDateRangeIndex( reportRows, dateRangeSlug ) {

    it should dynamically retrieve the row index, instead of always looking in the 0 - reportRows?.[ 0 ]
  • Loop through the reportRows first, and then apply existing search for the index of dateRangeSlug in each row, once found, dynamically update the row index and existing dateRange index
  • So, modified function will look something like this:

function getDateRangeIndex( reportRows, dateRangeSlug ) {
	let rowIndex = 0;
	let dateRange = 0;

	for ( const reportRow of reportRows ) {
		const foundDateRange = reportRow?.dimensionValues?.find(
			( dimension ) => dimension.value === dateRangeSlug
		);
		if ( foundDateRange ) {
			rowIndex = reportRows.indexOf( reportRow );
			dateRange = foundDateRange;
		}
	}

	const dateRangeIndex =
		reportRows?.[ rowIndex ]?.dimensionValues?.indexOf( dateRange );

	return dateRangeIndex;
}

Test Coverage

• No updates needed

QA Brief

Changelog entry

[10upsimon]

@zutigrm AC ✅

[10upsimon]

Thanks @zutigrm IB LGTM ✅ Moving to EB. I do recall seeing a helper function in one of the widgets to get the dynamic index, I believe added by Arafat. If I find it, I'll reference it in this issue for the engineer.