-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter extractors by actual capabilities #443
Comments
In the binary there's a flag to only enable plugins whose capabilities are met: osv-scalibr/binary/scalibr/scalibr.go Line 57 in 620a293
And in the library the user can specify their capacities and call list.FilterByCapabilities to enable only those extractors - osv-scalibr/extractor/filesystem/list/list.go Line 255 in 620a293
Is there anything more we should add? |
Should this function to return false by default for capabilities? |
Well that's the capability setup for the SCALIBR binary wrapper. When wrapped into a binary, SCALIBR always runs on a real filesystem so it makes sense to set all capabilities to true (unless --remote-image is specified which we take into account in the code). The one assumption the binary wrapper does make is that we can connect to the internet. If we want we can introduce an --offline flag or similar that would set this capability to false. |
We should filter extractors by actual capabilities. For example, only enable an extractor requiring network access when network access is available.
The text was updated successfully, but these errors were encountered: