Skip to content
This repository has been archived by the owner on Nov 28, 2024. It is now read-only.

Add another maintainer for continuity reasons #68

Open
afk11 opened this issue Aug 1, 2020 · 15 comments
Open

Add another maintainer for continuity reasons #68

afk11 opened this issue Aug 1, 2020 · 15 comments

Comments

@afk11
Copy link

afk11 commented Aug 1, 2020

Hi all

I've been using this package a while and have been getting the connection timeout issues for a good while. I see lots of other reports about it. But there has been no new releases of this library since 2018 even with a PR available as a fix.

I think having one or two people besides @ivy is important at this stage as the project is used in several projects, already does it's job pretty well, but will need ongoing maintenance with new go versions or as bugs are discovered.

@ivy is there someone you can think of who could do this already? I'd be willing to volunteer to review incoming PR's and issues if you don't have someone.

@razonyang
Copy link

@ivy ping again, sorry to bother you, but I really hope this project go forward.

@afk11
Copy link
Author

afk11 commented Aug 5, 2020

Emailed @ivy in a last ditch effort on this.

@harrisonhjones
Copy link

Let me know if you hear back; still happy to support this project if I can.

@wolveix
Copy link

wolveix commented Aug 15, 2020

@ivy @afk11 Any updates on this?

@afk11
Copy link
Author

afk11 commented Aug 18, 2020

Nothing back unfortunately. Probably time to create a new org, add 3 people, and try pick up where we left off. Is anyone particularly interested in taking lead on this or shall I go ahead?

@wolveix
Copy link

wolveix commented Aug 18, 2020

I don't mind taking lead, but you created the issue so feel free to go ahead. I'm happy to help with PRs etc. if needed.

@ivy
Copy link

ivy commented Aug 23, 2020

Hi everyone - I want to apologize for the silence. I recognize that a lot of these long-standing bugs are a huge inconvenience for everyone but unfortunately, I had to take a break for various personal reasons. I'm glad to have had a chance to reset and I'm hoping to continue work on this project in the near future (I don't want to promise a specific date just yet as I've just made a big move across states).

For what it's worth, I've been on the lookout for collaborators from the start of this fork and my only requirement has been that someone contributes consistently (in terms of either support on issues, code review, and/or code). Going forward, I can be more proactive in encouraging contributors to continue their participation but when it comes down to it, finding maintainers is always easier said than done.

If anyone does decide to fork and prepare various fixes and improvements (starting from the open pull requests here, possibly? 😄) I would be glad to integrate them as long as the work is of "good" (a loaded term) quality.

@afk11
Copy link
Author

afk11 commented Aug 23, 2020

Hi @ivy - great to hear you'll be available again soon. I'm sure we all appreciate not having to start afresh or look elsewhere entirely.

Might I encourage you to consider the bus factor - and what will happen if you're not available again for an extended period of time. There have been PR's open for some time, and having a fallback maintainer who can at perform keep-alive functions (review, merge, release) - as opposed to leading development to new places - is valuable IMO. The author of the next PR merged is probably a good place to start :)

@ivy
Copy link

ivy commented Aug 23, 2020

Might I encourage you to consider the bus factor - and what will happen if you're not available again for an extended period of time. There have been PR's open for some time, and having a fallback maintainer who can at perform keep-alive functions (review, merge, release) - as opposed to leading development to new places - is valuable IMO. The author of the next PR merged is probably a good place to start :)

@afk11 That's a fair concern you have and I'd like to know more about what you have in mind and what your criteria would be for a suitable maintainer. I may have misunderstood you but I would be skeptical that giving release privileges to the first person who contributes code would yield good results.

I'll continue to be on the lookout for good/trustworthy maintainers to add to the org. There's certainly more that I plan to do in this area, the least of which is making this need more prominent in the readme and pull request templates. My next question would be, what can be done to draw more interest in contributing to this project?


Also, @afk11 @razonyang @harrisonhjones @wolveix: What, in your opinions, are the most pressing PRs/issues that need addressing?

@wolveix
Copy link

wolveix commented Aug 24, 2020

It's good to hear from you @ivy, hopefully you'll add additional contributors to the org soon. With regards to which issues/PRs are the most pressing right now, I would definitely say #49 is one of the most important.

@harrisonhjones
Copy link

Some background: I personally don't have any code contributions to make to this package at this time but I do use it in a few projects. When I realized you were looking for help in #1 I thought this would be a good time to "give back" and help out a project which I rely on. I'm happy to do code reviews, triage pull requests, etc of others work or contribute code as needed. For example: you mentioned in #49 that you would write up a quick test for a bug but didn't find time to do it. In the future consider pinging me and I'll see if I have bandwidth. Contributing code does require me to chat with my employer but that hasn't been a big deal in the past.

If you are up for folks helping out in code reviews it might help to settle on a style guide. I'm personally a fan of Uber's but I'll work with whatever (including treating the existing code as "whatever").

@Pokerkoffer
Copy link

Any updates on this? It's been a while, any signs of life would be greatly appreciated :)

@harrisonhjones
Copy link

A new year and a new ping: any thoughts on this @ivy ?

@daemonfire300
Copy link

Ping?

@Lejla94
Copy link

Lejla94 commented Dec 14, 2021

Is this still maintained?
What will happen in the future on this package?
Ping. Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants