Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update linting for secrets #230

Closed
ltaylorsbl opened this issue Jul 13, 2023 · 2 comments
Closed

Update linting for secrets #230

ltaylorsbl opened this issue Jul 13, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@ltaylorsbl
Copy link

After installing the extension, I'm seeing some warnings in my workflow yaml file everytime I reference a secret. When I hover, the message says "Context access might be invalid."
githubSecret

I think it's reasonable that it does this, but it would be nice if there weren't so many false positives (even if they are just warnings). In this case I have two ideas:

  1. actually validate my secret name - since I signed in to GitHub, could it connect to my account and determine if the secret name is valid or not?
  2. ignore the secret name and validate the syntax only - when the variable context is secret.<secret_name>, could the extension strictly look at the syntax to determine validity?

Thank you!

@KetchupOnMyKetchup
Copy link
Contributor

Hi @ltaylorsbl

I see in the suggestions that the Secrets recommended are the ones that are in my repository and organization secrets:
image

I tried to set some of the secrets to ones I have in Settings and it doesn't have the warnings for me:
image

Could you please reload and re-login to the extension to make sure it is working properly? And if you see the issue please let me know information like the version of the extension, where you are using the extension (VS Code or browser), OS, etc?

Thanks!

@KetchupOnMyKetchup
Copy link
Contributor

Actually this looks like a dupe of this - #222

Closing this issue so we can track it all in one place. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

2 participants