-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposing a PR to fix a few small typos #145
Comments
How are these typos being missed by codespell running in our automated tests? |
@timgates42 Would be great if you could open a PR for it! @cclauss Great question about codespell. I feel like it has corrected other typos in the past, so it's working to some degree |
Thanks @StoicLoofah raised #146 |
There are small typos in: - docs/source/articles/creatingagameengineplugin.rst - docs/source/articles/whatsinareplay.rst - docs/source/tutorials/prettyprinter.rst - examples/sc2autosave.py - sc2reader/engine/engine.py - sc2reader/events/game.py - sc2reader/objects.py - sc2reader/resources.py Fixes: - Should read `aggregated` rather than `aggrated`. - Should read `account` rather than `acount`. - Should read `versatile` rather than `versitile`. - Should read `unnecessary` rather than `unncessary`. - Should read `targeting` rather than `targetting`. - Should read `substitution` rather than `substition`. - Should read `requirements` rather than `requirments`. Closes #145
@timgates42 You might consider contributing some of these off-by-just-one-letter fixes to codespell. Especially the account one might be done in other repos. |
Yeah that is a great idea @cclauss - Thanks! |
Interestingly @cclauss acount was added back in 2018 - codespell-project/codespell@3f94316 |
In fact only 2 from this list were missing in the latest version - codespell-project/codespell#2019 |
“Small moves.” -- Contact Thanks for doing this. |
Issue Type
[x] Bug (Typo)
Steps to Replicate and Expected Behaviour
aggrated
, however expect to seeaggregated
.acount
, however expect to seeaccount
.versitile
, however expect to seeversatile
.unncessary
, however expect to seeunnecessary
.targetting
, however expect to seetargeting
.substition
, however expect to seesubstitution
.requirments
, however expect to seerequirements
.Notes
Semi-automated issue generated by
/~https://github.com/timgates42/meticulous/blob/master/docs/NOTE.md
To avoid wasting CI processing resources a branch with the fix has been
prepared but a pull request has not yet been created. A pull request fixing
the issue can be prepared from the link below, feel free to create it or
request @timgates42 create the PR. Alternatively if the fix is undesired please
close the issue with a small comment about the reasoning.
/~https://github.com/timgates42/sc2reader/pull/new/bugfix_typos
Thanks.
The text was updated successfully, but these errors were encountered: