Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use date as version #2292

Closed
Freed-Wu opened this issue Jul 20, 2023 · 4 comments
Closed

Use date as version #2292

Freed-Wu opened this issue Jul 20, 2023 · 4 comments
Labels

Comments

@Freed-Wu
Copy link
Contributor

Can this project use date as version like 2023.7.1? currently, master-XXXXXX cannot compare which version is newer. but date can: 2023.7.1 is newer than 2023.6.29. It is convenient for the packager to compare which version is newer.

Related: termux/termux-packages#17457

@mxcl
Copy link

mxcl commented Jul 20, 2023

@teaxyz would also appreciate this.

Since every push to master triggers a release this would mean some days have multiple releases however. We could do calver+time to mitigate.

Prefacing the next thing I'm saying with: I totally understand why releases are cognitive overhead—ideally the project would migrate to real releases. Start at v0.0.1 by all means!

@DannyDaemonic
Copy link
Contributor

DannyDaemonic commented Jul 21, 2023

There's already a header generated containing a "build" number based on the current commit. When you run main you see it as:

main: build = 852 (294f424)

or:

main: build = 867 (ab0e26b)

I wonder if this build number could be used instead. Using larger numbers like these isn't unheard these days, for example, with projects like Firefox.

@netrunnereve
Copy link
Collaborator

That build number literally comes from the command git rev-list --count HEAD (from scripts/build-info.sh). It should be pretty easy to add that to the CI flow.

Copy link
Contributor

github-actions bot commented Apr 9, 2024

This issue was closed because it has been inactive for 14 days since being marked as stale.

@github-actions github-actions bot closed this as completed Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants