Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hw: sanitize Kernel::Signal_* classes #5416

Open
skalk opened this issue Jan 13, 2025 · 0 comments
Open

hw: sanitize Kernel::Signal_* classes #5416

skalk opened this issue Jan 13, 2025 · 0 comments
Labels
cleanup fixed

Comments

@skalk
Copy link
Member

skalk commented Jan 13, 2025

There are several minor, mostly cosmetic issues within the Kernel::Signal_* datastructures, like:

  • boolean value stated as numerics
  • nullptr stated as numeric
  • unused return values
  • several can_* conditional functions that should be asked before the actual function is called
@skalk skalk added the cleanup label Jan 13, 2025
skalk added a commit to skalk/genode that referenced this issue Jan 13, 2025
@skalk
hw: sanitize kernel's signal datastructures
5e1c17c 
* Move all Kernel::Signal_* structures to kernel/signal.*
* Remove return value of kill_signal_context, which wasn't evaluated
* Remove Kernel::Signal_context::can_kill
* Remove Kernel::Signal_context::can_submit
* Remove Kernel::Signal_receiver::can_add_handler
* Turn nullptr into cxx nullptr instead of just zero
* Turn boolean values into true/false instead of one/zero
* Always add to signal FIFO also if submit counter
  cannot get increased enough

Fix genodelabs#5416
@skalk skalk added the fixed label Jan 13, 2025
chelmuth pushed a commit that referenced this issue Jan 15, 2025
@skalk @chelmuth
hw: sanitize kernel's signal datastructures
673c97b 
* Move all Kernel::Signal_* structures to kernel/signal.*
* Remove return value of kill_signal_context, which wasn't evaluated
* Remove Kernel::Signal_context::can_kill
* Remove Kernel::Signal_context::can_submit
* Remove Kernel::Signal_receiver::can_add_handler
* Turn nullptr into cxx nullptr instead of just zero
* Turn boolean values into true/false instead of one/zero
* Always add to signal FIFO also if submit counter
  cannot get increased enough

Fix #5416
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@skalk