Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib/core-hw: depends on environment variable 'BOARD` #5414

Open
trimpim opened this issue Jan 10, 2025 · 2 comments
Open

lib/core-hw: depends on environment variable 'BOARD` #5414

trimpim opened this issue Jan 10, 2025 · 2 comments
Labels
fixed

Comments

@trimpim
Copy link
Contributor

trimpim commented Jan 10, 2025

When building <depot-usr>/bin/arm_v8a/base-hw-imx8mp_iot_gate with depot/create in a shell where
teh environment variable BOARD isn't set, in repos/base-hw/lib/mk/core-hw.inc an empty string is set as
BOARD_NAME.

I do not have currently an idea, how to proper fix this. In the meanwhile I have a patch that aborts building the archive
if the variable is not set.
trimpim added a commit to trimpim/genode that referenced this issue Jan 10, 2025
@trimpim
WIP: core-hw: detect unset BOARD variable
29c16fc 
Otherwise the platform driver will not be able to setup the
IOMUX correctly.

Issue genodelabs#5414
Issue gapfruit#2276
skalk added a commit to skalk/genode that referenced this issue Jan 10, 2025
@skalk
hw: ensure board_name is set as depot build
8d35a28 
When no BOARD variable is set via the build environment,
the board_name in the platform_info ROM needs to be set either.

Ref genodelabs#5360
Fix genodelabs#5414
@skalk
Copy link
Member

skalk commented Jan 10, 2025

@trimpim thank you for pointing us to this issue. It was not intended nor wanted behaviour, when adding the board name to the platform_info ROM inside of hw's core. I've prepared a commit 8d35a28, which should solve this issue.

@skalk skalk added the fixed label Jan 10, 2025
@trimpim
Copy link
Contributor Author

trimpim commented Jan 13, 2025

@skalk thanks for the quick fix. I integrated it in to our branch.

chelmuth pushed a commit that referenced this issue Jan 15, 2025
@skalk @chelmuth
hw: ensure board_name is set as depot build
b7d3d82 
When no BOARD variable is set via the build environment,
the board_name in the platform_info ROM needs to be set either.

Ref #5360
Fix #5414
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@skalk @trimpim