Fix weird legend for hourly tweet stats

[gedankenstuecke]

I don't exactly understand where these things come from, but should be fixable somehow.

[aashaka]

I am interested in fixing this issue. I have started working on it and will send a PR in a few days :)

[gedankenstuecke]

That’s great, thanks so much!

[aashaka]

To see the source of the problem, I extracted the hourly_stats data which was being fed to d3 in templates/tweet_display/index.html and used the MetricsGraphics Interactive Demo to tinker with it.

Turns out, the data works just fine when the x_accessor is a date, however, multiline graph with non-date x-values seem to have an inherent problem in the MetricsGraphics library itself.

In case we wish to really solve this issue without waiting for it to be corrected in the library, I can add linked graphs, which will look something like this. I can send in a PR for this if @gedankenstuecke agrees with it in the design sense.

Or we can wait if someone comes up with another hack. When I looked into the MetricsGraphics library, I found the following functions to be important for this issue: mg_process_multiple_y_accessors and mg_format_data_for_mouseover.

[gedankenstuecke]

I think we can keep the somewhat weird display for now, but would you want to submit an issue with this to the MetricsGraphics GitHub repository? If not I can do it too 😄

[aashaka]

Sure, I will submit an issue to that repository!

EDIT: Here is the filed issue - metricsgraphics/metrics-graphics#831

[gedankenstuecke]

Awesome, thanks!