Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video does not work on Safari with gatsby-plugin-offline #13615

Closed
vanwalj opened this issue Apr 24, 2019 · 9 comments
Closed

Video does not work on Safari with gatsby-plugin-offline #13615

vanwalj opened this issue Apr 24, 2019 · 9 comments
Labels
status: blocked This issue/PR can't be solved at the moment and shouldn't be closed/merged topic: plugins-PWA Issues related to PWA: the gatsby-plugin-offline and gatsby-plugin-manifest plugins type: bug An issue or pull request relating to a bug in Gatsby type: upstream Issues outside of Gatsby's control, caused by dependencies

Comments

@vanwalj
Copy link

vanwalj commented Apr 24, 2019

Description

Caching video with gatsby-plugin-offline works almost everywhere, except on Safari

After digging a bit, it seems that Safari do some pretty weird stuff when loading video, I found this blog post interesting

A quick fix would probably be to exclude video files from the gatsby-plugin-offline cache, but I can't find a way to do so.

Steps to reproduce

You can check out the project I'm currently working on https://staging.ouaille-note-festival.fr

  • Visit the home page with Safari iOS or macOS
  • A video should start playing
  • Reload the page and the video is not loading anymore

If you reproduce those steps with Google Chrome it works well

Expected result

The video should play on every latest browser

Actual result

It doesn't load once cached Safari

Environment

Latest stable Safari version on iOS and macOS

@jimdel
Copy link

jimdel commented Apr 25, 2019

I can start taking a look at this one

@jimdel jimdel self-assigned this Apr 25, 2019
@vanwalj
Copy link
Author

vanwalj commented Apr 25, 2019

This seems to be the root issue GoogleChrome/workbox#1663
Unfortunately it doesn't seems straightforward to fix 😨

@freiksenet freiksenet added status: blocked This issue/PR can't be solved at the moment and shouldn't be closed/merged type: bug An issue or pull request relating to a bug in Gatsby type: upstream Issues outside of Gatsby's control, caused by dependencies labels May 2, 2019
@jimdel jimdel removed their assignment May 5, 2019
@gatsbot
Copy link

gatsbot bot commented May 26, 2019

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here.

If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!

As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contributefor more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

@gatsbot gatsbot bot added the stale? Issue that may be closed soon due to the original author not responding any more. label May 26, 2019
@gatsbot
Copy link

gatsbot bot commented Jun 6, 2019

Hey again!

It’s been 30 days since anything happened on this issue, so our friendly neighborhood robot (that’s me!) is going to close it.

Please keep in mind that I’m only a robot, so if I’ve closed this issue in error, I’m HUMAN_EMOTION_SORRY. Please feel free to reopen this issue or create a new one if you need anything else.

As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks again for being part of the Gatsby community!

@gatsbot gatsbot bot closed this as completed Jun 6, 2019
@jamesvclements
Copy link

🤕 Any solutions for this?

@vanwalj
Copy link
Author

vanwalj commented Aug 28, 2019

@jamesvclements didn't find a proper way to solve this, I had to remove gatsby-plugin-offline 😟

@cwgw
Copy link
Contributor

cwgw commented Sep 10, 2019

I also decided to drop offline support because of this issue.

I'd like to keep this open in the hopes that some brave person takes it on. Here's the strategy that the Workbox team currently suggests:

https://developers.google.com/web/tools/workbox/guides/advanced-recipes#cached-av

@cwgw cwgw reopened this Sep 10, 2019
@gatsbot
Copy link

gatsbot bot commented Sep 21, 2019

Hey again!

It’s been 30 days since anything happened on this issue, so our friendly neighborhood robot (that’s me!) is going to close it.

Please keep in mind that I’m only a robot, so if I’ve closed this issue in error, I’m HUMAN_EMOTION_SORRY. Please feel free to reopen this issue or create a new one if you need anything else.

As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks again for being part of the Gatsby community!

@gatsbot gatsbot bot closed this as completed Sep 21, 2019
@cwgw cwgw added the not stale label Oct 24, 2019
@cwgw cwgw reopened this Oct 24, 2019
@danabrit danabrit added topic: plugins-PWA Issues related to PWA: the gatsby-plugin-offline and gatsby-plugin-manifest plugins and removed stale? Issue that may be closed soon due to the original author not responding any more. labels May 21, 2020
@LekoArts
Copy link
Contributor

LekoArts commented May 26, 2020

I'll close this as it's an upstream issue. It's supposed to be fixed in the latest Safari Technology Preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: blocked This issue/PR can't be solved at the moment and shouldn't be closed/merged topic: plugins-PWA Issues related to PWA: the gatsby-plugin-offline and gatsby-plugin-manifest plugins type: bug An issue or pull request relating to a bug in Gatsby type: upstream Issues outside of Gatsby's control, caused by dependencies
Projects
None yet
Development

No branches or pull requests

7 participants