Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WayVR display names converted to lowercase #158

Open
SamWilsn opened this issue Feb 16, 2025 · 1 comment
Open

WayVR display names converted to lowercase #158

SamWilsn opened this issue Feb 16, 2025 · 1 comment

Comments

@SamWilsn
Copy link
Contributor

Introduced in 3c79260, it looks like the keys in the displays member of WayVRConfig get converted to lowercase. Possibly not a bug, but if this is intended behavior, the config file should be updated.

@LukasLichten
Copy link

I have been wondering why the apps from the catalog failed to launch with for example action_app_click failed: Cannot find display named 'Disp2'.
Now, I don't use this feature currently, and had just the default wayvr.yaml, and did not have the time nor interest to dive deeper to find what broke, but had it at the back of my mind.

Now, with the information that displays are converted to lowercase, and as linked above the default config has Displays names with upper cases, that are then also used with the same spelling (logically) for the target_display.
But it seems target_display values do not get "normalized", so running as is gives you an error, but you can get it to work by changing the target_display to lower case manually.

But as it stands the default config (and old user configs based on it) are borked, and the error message is a complete red herring in this case, so I say this is a bug till both behave the same (lowercase both is probably the best solution).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants