From 11aa0bca5afce8bfaf605d7d3273601015a21b71 Mon Sep 17 00:00:00 2001
From: Albert Chu <chu11@llnl.gov>
Date: Mon, 2 Dec 2024 14:36:55 -0800
Subject: [PATCH] rfc7: break long test expressions to one per line

Problem: We've adopted a defacto guideline that long test expressions
connected by "AND" or "OR" operators should be broken to one test
expression per line.  This is not documented.

Add this to RFC 7.
---
 spec_7.rst | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/spec_7.rst b/spec_7.rst
index 0d73c10..04149bb 100644
--- a/spec_7.rst
+++ b/spec_7.rst
@@ -86,6 +86,24 @@ to one parameter per line, at the same indent level.  Example:
                   FLUX_NODEID_ANY,
                   FLUX_RPC_RESPONSE);
 
+10. Long test expressions connected by "AND" or "OR" operators SHOULD
+be broken to one test expression per line at the same indent level.
+Example:
+
+  .. code-block:: c
+
+    if (out->type == MY_EXPECTED_TYPE
+        && out->bytes > LOW_END_RANGE
+        && out->bytes < HIGH_END_RANGE) {
+        ...
+    }
+
+  .. code-block:: c
+
+    if (flux_event_subscribe (h, "event.foo") < 0
+        || flux_event_subscribe (h, "event.bar") < 0) {
+        ...
+    }
 
 Variable Names
 ==============