flameshot launcher have some problems

[Alaskra]

Flameshot Version

Flameshot v12.0.0 (10a8c31)
Compiled with Qt 5.15.4

Installation Type

Compiled from source

Operating System type and version

5.4.197-1-MANJARO

Description

when use flameshot launcher to take screenshot, two problems occur:

1. the help message doesn't disappear, until start another selection
2. the content of the button that show X or Y demensions of the selection disappear

Steps to reproduce

1. run flameshot launcher
2. press Take new screenshot button
3. then the problem happen as above shows

ps: if run falmeshot as daemon and right click tray icon to open launcher, the problem also happen.

Screenshots or screen recordings

System Information

> inxi --width 80 --system --graphics
System:
Host: alaskra-redmibook14 Kernel: 5.4.197-1-MANJARO arch: x86_64 bits: 64
Desktop: KDE Plasma v: 5.24.5 Distro: Manjaro Linux
Graphics:
Device-1: Intel CometLake-U GT2 [UHD Graphics] driver: i915 v: kernel
Device-2: NVIDIA GP108M [GeForce MX250] driver: nvidia v: 515.48.07
Display: x11 server: X.Org v: 21.1.3 driver: X: loaded: modesetting,nvidia
gpu: i915 resolution: 1920x1080~60Hz
OpenGL: renderer: Mesa Intel UHD Graphics (CML GT2) v: 4.6 Mesa 22.1.1

[borgmanJeremy]

I can replicate the missing icon but not the issue with the help message. Can you take a video recording of what you mean with the help message just to make sure I fully understand?

[Alaskra]

I think the help message should hide after initial selection but it hide after select region manually.

20220629000315.mp4

Sorry, the uploaded above is a video, but I don't know why it's recognized as an audio. You may download it and view it by local player.

[borgmanJeremy]

#2734 fixes the size indicator.

[borgmanJeremy]

In my opinion the help message is not a bug but I would also like @mmahmoudian to weigh in. The reason I think it is not a bug:

• There is an option to disable it, if the user has it enabled, then we should display the help message
• Even though the help message occludes the image, it does not get saved or copied with the final image so it does not affect the result
• The help message dissapears if the widget is resized. Maybe we could also hide it if a tool is clicked

[mmahmoudian]

@borgmanJeremy Sorry for the late reply. I just got back from a trip and I have lots of notifications and unread issues that I should go through.

@Alaskra I agree with @borgmanJeremy, this is not a bug and is intended behavior. The idea is that users should have a quick help displayed to them so that they know what to do and how to use the software. You have used the launcher with a pre-selected region, therefore Flameshot opens, select the region, and also displays the help. The help goes away as soon as youinteract with Flameshot. You have just got "unlucky" that the selected region and the help message have overlapped. if you try flameshot gui --region 100x100+100+100 you will see that the help message will be outside of your selected region and now it feels more natural. I agree that the help message and selected region overlapping feels a bit weird, but I have no solution to make it look better. What we have is the best I can think of that the help message covers the buttons. If you have any idea on how this can be improved, feel free to suggest it to us.

Btw, regarding why Github thinks your mp4 is audio, I downloaded it and reformatted it with ffmpeg and resized it, and Github still considers it as audio. should be some sort of bug on GH end.