Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flameshot shifts screen by a few pixels on MacOS #2612

Open
nohehf opened this issue May 19, 2022 · 21 comments
Open

Flameshot shifts screen by a few pixels on MacOS #2612

nohehf opened this issue May 19, 2022 · 21 comments
Labels
Unconfirmed Bug The bug is not confirmed by anyone else.

Comments

@nohehf
Copy link

nohehf commented May 19, 2022

Flameshot Version

Flameshot v11.0.0 (ad1bf28)
Compiled with Qt 5.15.2
darwin: 21.1.0
osx: 12.0

Installation Type

Linux, MacOS, or Windows Package manager (apt, pacman, eopkg, choco, brew, ...)

Operating System type and version

macOS Monterey v12.0.1, Apple M1 Pro

Description

When trying to take a screenshot, flameshot insanely zooms in, leaving only the top-right part of the screen accessible to screen shot. I'm on google chrome, and have multiple screens. Also I can only screen shot the main screen.

Steps to reproduce

  1. Start flameshot screenshot onto google chrome

Screenshots or screen recordings

Screen.Recording.2022-05-19.at.10.17.59.mov

System Information

Screenshot 2022-05-19 at 10 19 47

Screenshot 2022-05-19 at 10 20 26

@nohehf nohehf added the Unconfirmed Bug The bug is not confirmed by anyone else. label May 19, 2022
@borgmanJeremy
Copy link
Contributor

Does this happen after you change you monitor setup? If so, try restarting flameshot.

@nohehf
Copy link
Author

nohehf commented May 19, 2022

You're right, thought I had already done it my bad. Tho I still have always a little zoom in, which is pretty annoying (see video, how the graph at the bottom gets cropped).

Screen.Recording.2022-05-19.at.20.51.55.mov

@mmahmoudian
Copy link
Member

@nohehf As far as I can see, this is not a zoom effect, but there is downwards shift of the image. Note the additional black region on top of the image. How does you monitor setup look like when you face this issue?

@nohehf
Copy link
Author

nohehf commented May 20, 2022

Right, it's shifting, and I'm only on my laptop screen.

@borgmanJeremy borgmanJeremy changed the title Flameshot zooms in & can't handle multiple screens on mac m1. Flameshot shifts screen by a few pixels on MacOS May 20, 2022
@borgmanJeremy
Copy link
Contributor

The other issue specifically pointed out that this is on a screen with a notch. I wonder if its related to that and Qt is using the region below the notch to draw full screen instead of the region above the notch. I have no way to test / work on this since I have an air.

@jasonycw
Copy link

jasonycw commented Jun 13, 2022

I have been experiencing the exact same issue on the macbook with notch. I think it's due to the way MacOS handling the notch with a "full screen application"

With normal screen, all full screen application will occupied the whole screen, so when Flameshot capture the screen and open a new full screen application for cropping, the screen looks fine.

However, on the macbook pro's notched screen, all full screen application cannot occupied the whole screen, so when when Flameshot capture the screen and open a new full screen application for cropping, the screen looks like it's shifted downward.

Screen.Recording.2022-06-13.at.10.17.04.AM.mov
Screen.Recording.2022-06-13.at.10.07.53.AM.3.mov

You can try mimic the behavior on a regular screen by trigger Flameshot screenshot and without dragging anything, swipe touchpad to open mission control, drag Flamshot into a regular space, resize the Flameshot window. You will see the screen will not be resized and it will be "cropped"

Screen.Recording.2022-06-13.at.10.26.45.AM.mov

I think if Flameshot can scale down the screenshot into within the windows size, then it should work better on a notched screen.

@jasonycw
Copy link

FYI, wIth the new version 12, the magnifier when taking screenshot also shift down/up a few pixel

@jasonycw
Copy link

Here is a screen capture for reference

Screen.Recording.2022-06-27.at.10.11.22.AM.mov

@AmandaBSobrinho
Copy link

I was able to reproduce the same issue here in a MacBook without the notch by enabling the option "Automatically hide and show the menu bar in full screen", in Dock & Menu Bar (macOS 12.6).

@monochroumme
Copy link

monochroumme commented Nov 26, 2022

Happens in my case too, it's because of the notch on 2021 Macbooks. Apps don't take the top of the screen to not be hidden under the notch and the same happens in the flameshot app. In other apps, the scroll area is increased to compensate the decrease of the height of the window whereas flameshot simply crops the bottom of the screen. Any way to resolve the issue? For example, by scaling down the image while editing or adding scroll?

telegram-cloud-photo-size-2-5195078186977839243-y
image

@jorpilo
Copy link

jorpilo commented Feb 17, 2023

Same here, is there any way to prevent it from shifting the screen? or just avoid going full screen when doing the screenshot?

@sonterix
Copy link

sonterix commented May 18, 2023

The same issue on Mac OS and not only for full screen. This happens all the time. When you full screen, you have this moved-down screen and the app will move you from full screen to 'normal' after the screenshot. When you are on the 'normal' screen you will have a shifted-down screen.
Is there any way to fix it? Because as I can see devs are ignoring this from May 19, 2022.

Flameshot v12.1.0 (96c2c82)
Compiled with Qt 5.15.5
darwin: 21.6.0
osx: 12.6

@kYem
Copy link

kYem commented Jan 12, 2024

For me this seems even more extreme, but maybe that to do with some animation?
image

vs build in macOS screenshot works just fine without any adjustment

image

@gonzaloafidalgo
Copy link

+1
Flameshot v12.1.0 (96c2c82)
Compiled with Qt 5.15.5
osx: 14.2.1

@volk-ov
Copy link

volk-ov commented Mar 21, 2024

+1
Flameshot v12.1.0 (96c2c82)
Compiled with Qt 5.15.5
MacOS 14.3.1 (23D60)

@julian-zatloukal
Copy link

+1
Flameshot v12.1.0 (96c2c82)
Compiled with Qt 5.15.5
osx: 14.4

@davidneyravyr
Copy link

+1
Flameshot v12.1.0 (96c2c82)
Compiled with Qt 5.15.5
osx: 14.4

please FIX!

@kopach
Copy link

kopach commented Jun 10, 2024

Restarting Flameshot as mentioned here #2612 (comment) works for me. Kinda workaround, but at least I need to do this only once after monitor connect/disconnect

@davidneyravyr
Copy link

@kopach remember this thread is for "notch" inside macbook screen. is mentioned by #2612 (comment)

@davidneyravyr
Copy link

Happens in my case too, it's because of the notch on 2021 Macbooks. Apps don't take the top of the screen to not be hidden under the notch and the same happens in the flameshot app. In other apps, the scroll area is increased to compensate the decrease of the height of the window whereas flameshot simply crops the bottom of the screen. Any way to resolve the issue? For example, by scaling down the image while editing or adding scroll?

telegram-cloud-photo-size-2-5195078186977839243-y image

any way to fix this? native screenshot dont have this bug.

@Untersander
Copy link

Untersander commented Jun 11, 2024

I have the same issue with the image shifting downwards on a macbook pro without a notch.
I believe the PR #3625 could solve this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Unconfirmed Bug The bug is not confirmed by anyone else.
Projects
None yet
Development

No branches or pull requests