Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Linux arm builds (32bit and 64bit) #1444

Closed
Itai-Nelken opened this issue Mar 10, 2021 · 14 comments
Closed

add Linux arm builds (32bit and 64bit) #1444

Itai-Nelken opened this issue Mar 10, 2021 · 14 comments
Labels
Linux Linux specific issue

Comments

@Itai-Nelken
Copy link

I use Flameshot a lot on my Raspberry Pi and because the version of flameshot available from the APT repositories is pretty old and missing some features that I use I compile it from source. but I change OS's a lot and compiling Flameshot from source each time isn't ideal.

can you add Linux ARM builds to the next releases please?

Thanks a lot!

@borgmanJeremy
Copy link
Contributor

borgmanJeremy commented Mar 10, 2021

Someone just needs to update the github CI and be available to test the ARM builds.

@Itai-Nelken
Copy link
Author

I can test them, but I don't know how to update the github CI.

@borgmanJeremy
Copy link
Contributor

After further though, rather than triple our CI load to build on arm64 and armv7 I will only officially support snap installs for ARM.

@Itai-Nelken
Copy link
Author

thats ok with me. though could you do flatpak instead?

@borgmanJeremy
Copy link
Contributor

I'm going to start with snap since they supposedly make it very easy to release on arm.

@Itai-Nelken
Copy link
Author

I'm going to start with snap since they supposedly make it very easy to release on arm.

ok, thanks a lot anyway!

@holazt holazt added the Linux Linux specific issue label Mar 12, 2021
@holazt
Copy link
Member

holazt commented Mar 13, 2021

@Itai-Nelken #1460
You can download the ARM version of the deb from our CI daily build now.

/~https://github.com/flameshot-org/flameshot/pull/1460/checks?check_run_id=2102541059

image
Or
image

Can you test them?
debian-10 arm64 download link https://we.tl/t-St94EzJDxY
debian-10 armhf download link https://we.tl/t-cTwFSHy8QR

@Itai-Nelken
Copy link
Author

@ZetaoYang the armhf one works, but is it normal for the tray icon to be a 'i' (information)?
I don't have a arm64 OS currently flashed, I will flash one to a sd card later this week and test the arm64 deb.

@mmahmoudian
Copy link
Member

@Itai-Nelken I think the "i" icon is related to #1378

@Itai-Nelken
Copy link
Author

@mmahmoudian I'm pretty sure its the same issue as well after reading it, maybe if I set flameshot to autostart on login and reboot it will fix the problem?

@mmahmoudian
Copy link
Member

mmahmoudian commented Mar 13, 2021

I think the fix is on the horizon based on Jeremy's comment

Does the "i" goes away after some time?

@Itai-Nelken
Copy link
Author

Does the "i" goes away after some time?

@mmahmoudian no, flameshot is already running for 1 hour and the 'i' is still there.

@borgmanJeremy
Copy link
Contributor

It's a known bug. It's not flameshot issue but I'm going to just remove the info icon. Taking a break for a few days but I'm targeting a patch release next weekend that includes this fix.

@Itai-Nelken
Copy link
Author

It's a known bug. It's not flameshot issue but I'm going to just remove the info icon. Taking a break for a few days but I'm targeting a patch release next weekend that includes this fix.

thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Linux Linux specific issue
Projects
None yet
Development

No branches or pull requests

4 participants