diff --git a/sdks/hermes-engine/utils/build-apple-framework.sh b/sdks/hermes-engine/utils/build-apple-framework.sh index 82ad18f1e9fb3b..df1fe0c299c204 100755 --- a/sdks/hermes-engine/utils/build-apple-framework.sh +++ b/sdks/hermes-engine/utils/build-apple-framework.sh @@ -90,9 +90,9 @@ function create_universal_framework { done mkdir universal - xcodebuild -create-xcframework $args -output "universal/hermes.xcframework" + xcodebuild -create-xcframework "$args" -output "universal/hermes.xcframework" - for platform in $@; do + for platform in "$@"; do rm -r "$platform" done diff --git a/sdks/hermes-engine/utils/build-ios-framework.sh b/sdks/hermes-engine/utils/build-ios-framework.sh index e13598181d829c..771f39f79779d2 100755 --- a/sdks/hermes-engine/utils/build-ios-framework.sh +++ b/sdks/hermes-engine/utils/build-ios-framework.sh @@ -4,6 +4,7 @@ # This source code is licensed under the MIT license found in the # LICENSE file in the root directory of this source tree. +# shellcheck source=xplat/js/react-native-github/sdks/hermes-engine/utils/build-apple-framework.sh . ./utils/build-apple-framework.sh if [ ! -d destroot/Library/Frameworks/universal/hermes.xcframework ]; then diff --git a/sdks/hermes-engine/utils/build-mac-framework.sh b/sdks/hermes-engine/utils/build-mac-framework.sh index 79040c2d0babdb..e1f9abf81a4a41 100755 --- a/sdks/hermes-engine/utils/build-mac-framework.sh +++ b/sdks/hermes-engine/utils/build-mac-framework.sh @@ -4,7 +4,9 @@ # This source code is licensed under the MIT license found in the # LICENSE file in the root directory of this source tree. +# shellcheck source=xplat/js/react-native-github/sdks/hermes-engine/utils/build-apple-framework.sh . ./utils/build-apple-framework.sh + if [ ! -d destroot/Library/Frameworks/macosx/hermes.framework ]; then mac_deployment_target=$(get_mac_deployment_target)