-
-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run git-hooks more correctly #2483
base: master
Are you sure you want to change the base?
Conversation
859aa5a
to
2d90eb5
Compare
Is there any way to write a test for this? |
In GitoxideLabs/gitoxide@51bbb86#diff-b1f4fc8d8a8a51923a922a937745a1f5665443821b5c4df58efa44c7c4515216 there is a check if the file returned by path() exists. But that isn't really a useful test. Maybe there could be some sort of integration test that creates a git-repo with hooks that then runs run_hook. But that wouldn't really help as that would only test one setup and this is about making it work on as many setups as possible. |
we do exactly that in the hooks unittests |
running the tests with |
Why is git only adds |
I think on non-Windows platforms it's best to just execute the hooks directly. I don't see a reason to use a shell. |
This Pull Request fixes #2482.
It changes the following:
I followed the checklist:
make check
without errorsDidn't test this on Windows