Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove platform-specific things from "common" segment files #165

Open
ethteck opened this issue Sep 22, 2022 · 0 comments
Open

Remove platform-specific things from "common" segment files #165

ethteck opened this issue Sep 22, 2022 · 0 comments

Comments

@ethteck
Copy link
Owner

ethteck commented Sep 22, 2022

Spimdisasm lives in most segment files under segtypes/common/ now. It's not a huge deal, but technically spimdisasm is mips only, so there's nothing "common" about it.

We should probably move the existing "common" files into a mips subdirectory and have n64 and psx files extend the mips versions of all the classes, changing things as needed. Common can contain basic platform-agnostic stuff, or it can just go away if there's deemed to not be enough of that to warrant that abstraction layer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant