-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possible name change for vb_epidist
class
#93
Comments
Tagging with dev day for discussion on {epiparameter} development day. |
I'm questioning whether the {epiparameter} package should contain a The @Bisaloo and @chartgerink in terms of development I'm hoping to simplify and streamline {epiparameter} over the next few weeks. Do you agree with removing this? @avallecam and @CarmenTamayo do you use |
To clarify, epidemiological parameters for vector-borne diseases can still be included in epiparameter but as "simple" So, what we would be losing here is the fact that the |
Yes.
Yes, plus the S3 methods for the class which are apply the The reasoning behind adding the The intrinsic and extrinsic parameters are linked by the For linking human and vector parameters from different studies, I think we can leave this to users of the package. |
I'm all for streamlining in case keeps scope of the functionality the same. I did a bit of code-browsing and do not see any immediate issues. As the maintainer @joshwlambert I trust your final judgment on the applicability 👍 Appreciate being pinged and looped in 😊 |
I agree that using the |
Not until now. We do not have any case study based on vector-borne diseases yet, as far as I'm aware. In order to provide informed feedback to this issue, we should plan to find a used case for this. |
Closing as this issue was addressed in #359. |
The
vb_epidist
class currently has two slots calledintrinsic_epidist
andextrinsic_epidist
. It has been pointed out that these might be unclear and perhapshuman_epidist
andvector_epidist
would be clearer. I'm unsure of which is preferred. Please comment on this issue with any preference.The text was updated successfully, but these errors were encountered: