New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cypress tests fail under rust crypto #26073

Closed

richvdh opened this issue Aug 29, 2023 · 3 comments

Assignees

Labels

A-Testing T-Task Team: Crypto

Member

richvdh commented Aug 29, 2023 •

edited

Loading

Current situation, based on https://cloud.cypress.io/projects/ppvnzg/runs/17700/overview:

A lot of the read-receipts tests are still failing, despite Fix read receipt tests with incorrect read counts matrix-org/matrix-react-sdk#11465. Presumably due to Notification counts may be incorrectly reset by sent messages matrix-org/matrix-js-sdk#3684.
The soft-logout tests intermittently report things like null pointer passed to rust, despite Fix incompatibility of Soft Logout with Element-R matrix-org/matrix-react-sdk#11468. This is because the shutdown of the rust SDK caused by soft-logout is racing with other operations. I have PRs in progress to fix this (RustCrypto.getCrossSigningStatus: check the client is not stopped matrix-org/matrix-js-sdk#3682, Improve error handling for DeviceListener matrix-org/matrix-react-sdk#11484)
"should be able to add and remove filters via keyboard" is also flaky on legacy crypto: Flaky cypress test "Spotlight > should be able to add and remove filters via keyboard" #26053

The text was updated successfully, but these errors were encountered:

richvdh self-assigned this

richvdh changed the title ~~Fix cypress tests~~ Cypress tests fail under rust crypto

richvdh mentioned this issue

Improve error handling for DeviceListener matrix-org/matrix-react-sdk#11484

Merged

germain-gg added T-Task A-Testing Team: Crypto labels

Member Author

richvdh commented Aug 31, 2023

As of https://cloud.cypress.io/projects/ppvnzg/runs/17774, the only tests failing are the read-receipts tests, presumably matrix-org/matrix-js-sdk#3684.

Member Author

richvdh commented Sep 7, 2023

Now that matrix-org/matrix-js-sdk#3684 is fixed, this seems to be working 🎉

richvdh closed this as completed

Member Author

richvdh commented Sep 7, 2023

see /~https://github.com/matrix-org/matrix-js-sdk/actions/runs/6106756558 for example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment