Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unread count from threads is not reset #6524

Closed
manuroe opened this issue Aug 3, 2022 · 7 comments
Closed

Unread count from threads is not reset #6524

manuroe opened this issue Aug 3, 2022 · 7 comments
Assignees
@gileluard
Labels
A-Room-List A-Threads Message threading to simplify the Timeline O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems T-Epic Issue is at Epic level Team: Delight Z-Chronic

Comments

@manuroe
Copy link
Member

manuroe commented Aug 3, 2022

Steps to reproduce

This comes from a very generic chronic issue which says: "Users should only ever be shown badges on a room if it has unread messages - badges should not lag behind reality."
I am aware there is an issue when there are threads in the room. It is reproductible in this way:

  1. Alice and bob are in a room with threads
  2. Alice is on the room list on EI
  3. Bob sends a message in a thread
  4. Alice sees the unread count in the room list increase
  5. Alice opens the room and comes back to the room list

-> The unread count stays the same.

If you open the room on EW, the unread count is automatically reset. This is what happened at the end of the attached video.

I am pretty sure that EW had the issue not so long ago.

RPReplay_Final1659522504.MP4

Outcome

Users should only ever be shown badges on a room if it has unread messages - badges should not lag behind reality.

Your phone model

No response

Operating system version

No response

Application version

1.8.24

Homeserver

No response

Will you send logs?

No
@manuroe manuroe added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Aug 3, 2022
@manuroe manuroe added A-Room-List S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Aug 3, 2022
@manuroe
Copy link
Member Author

manuroe commented Aug 3, 2022

I put labels to get a P1 bug. It is part of the chronic issues. It affects the trust people can have on the system.

@pixlwave
Copy link
Member

pixlwave commented Aug 4, 2022

@manuroe I've been trying to reproduce this and from what I can tell this is working as "expected".

Doing steps 1 to 4 and then:

  • Step 5 on iOS and like you say the unread count stays the same.
  • Step 5 on Web (with the threads panel closed) and the unread count also stays the same.
  • Step 5 on iOS but opening the thread before returning to the home screen and the unread count goes to 0.
  • Step 5 on Web (with the threads panel closed) and the unread count only clears when I've opened the thread.

@manuroe
Copy link
Member Author

manuroe commented Aug 4, 2022

My bad. My thread panels on web was open 🤦 .
We need to dig why we are getting this feedback: it happened here early before threads and after threads.
Threads create definitely an issue but it is more a UX issue.

@manuroe
Copy link
Member Author

manuroe commented Aug 4, 2022

Another issue will be created after the discovery phasis

@manuroe manuroe closed this as completed Aug 4, 2022
@manuroe
Copy link
Member Author

manuroe commented Aug 4, 2022

Well, this issue, UX or technical, needs to be fixed

@manuroe manuroe reopened this Aug 4, 2022
@manuroe manuroe added the A-Threads Message threading to simplify the Timeline label Aug 4, 2022
@germain-gg
Copy link
Contributor

Related to element-hq/element-meta#196

@kittykat kittykat added the T-Epic Issue is at Epic level label Oct 4, 2022
@gileluard
Copy link
Contributor

Should be fixed with element-hq/element-meta#196

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gileluard gileluard

Labels
A-Room-List A-Threads Message threading to simplify the Timeline O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems T-Epic Issue is at Epic level Team: Delight Z-Chronic
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@kittykat @stefanceriu @germain-gg @pixlwave @manuroe @gileluard @daniellekirkwood