From 4d7f4da6b114dd7d12f7ecbf16edcbe0a551c989 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Vo=CC=88lker=2C=20Tilman?= Date: Wed, 14 Mar 2018 10:43:29 +0100 Subject: [PATCH 1/2] fix(osx): Code signing need proxy to reach internet --- packages/electron-builder-lib/src/windowsCodeSign.ts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/electron-builder-lib/src/windowsCodeSign.ts b/packages/electron-builder-lib/src/windowsCodeSign.ts index ea2e2fade05..e05bed599db 100644 --- a/packages/electron-builder-lib/src/windowsCodeSign.ts +++ b/packages/electron-builder-lib/src/windowsCodeSign.ts @@ -241,6 +241,10 @@ function computeSignToolArgs(options: WindowsSignTaskConfiguration, isWin: boole args.push(isWin ? "/ac" : "-ac", vm.toVmFile(options.options.additionalCertificateFile)) } + if (process.env.HTTPS_PROXY) { + args.push("-p", process.env.HTTPS_PROXY) + } + if (isWin) { // must be last argument args.push(inputFile) From 48fbb8bf275daf7f07d50534d90729a8dfb98eef Mon Sep 17 00:00:00 2001 From: Vladimir Krivosheev Date: Sat, 17 Mar 2018 09:22:51 +0100 Subject: [PATCH 2/2] Update windowsCodeSign.ts --- packages/electron-builder-lib/src/windowsCodeSign.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/electron-builder-lib/src/windowsCodeSign.ts b/packages/electron-builder-lib/src/windowsCodeSign.ts index e05bed599db..a1fdce3101d 100644 --- a/packages/electron-builder-lib/src/windowsCodeSign.ts +++ b/packages/electron-builder-lib/src/windowsCodeSign.ts @@ -241,7 +241,7 @@ function computeSignToolArgs(options: WindowsSignTaskConfiguration, isWin: boole args.push(isWin ? "/ac" : "-ac", vm.toVmFile(options.options.additionalCertificateFile)) } - if (process.env.HTTPS_PROXY) { + if (!isWin && process.env.HTTPS_PROXY) { args.push("-p", process.env.HTTPS_PROXY) }