Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scm] support 'undo last commit' #6652

Closed
vince-fugnitto opened this issue Nov 27, 2019 · 3 comments
Closed

[scm] support 'undo last commit' #6652

vince-fugnitto opened this issue Nov 27, 2019 · 3 comments
Labels
enhancement issues that are enhancements to current functionality - nice to haves git issues related to git scm issues related to the source control manager

Comments

@vince-fugnitto
Copy link
Member

Description

As a user, I'd like to be able to undo last commit similarly to VS Code.
At the moment, the option is not available from the context menu:

Screen Shot 2019-11-27 at 11 56 19 AM

I noticed the PR #1779 but I do not see the option (where the amend is at the bottom).
@kittaakos is it perhaps a regression?

@vince-fugnitto vince-fugnitto added enhancement issues that are enhancements to current functionality - nice to haves git issues related to git scm issues related to the source control manager labels Nov 27, 2019
@westbury
Copy link
Contributor

If I run with the native git package (@theia/git) then I see the same menu as you show above and I see the HEAD COMMIT section at the bottom with the 'Amend' button.

If I run with vscode built-in git extension ( https://registry.npmjs.org/@theia/vscode-builtin-git/-/vscode-builtin-git-0.2.1.tgz) then I see additional items in the menu such as Pull (Rebase), Sync, Checkout to..., Publish Branch, and Undo Last Commit. There is no HEAD COMMIT section when using vscode's git extension.

I don't see a regression. It is true that some items are missing from the menu in the @theia/git extension compared to the vscode extension. However the requirement at the time #4279 was merged was only that the extension supported at least what was previously supported in Theia, not that it supports everything in the vscode extension.

HEAD COMMIT sections shows only if the extension supports Theia's amend api, which of course the vscode extension does not. 'Undo Last Commit' does the same thing as the 'Amend' button but has no feedback and does not allow the Amend to be unamended (one of the many reasons why we want to continue to use the native Theia extension).

@kittaakos
Copy link
Contributor

@kittaakos is it perhaps a regression?

No, it was removed on purpose.

@vince-fugnitto
Copy link
Member Author

@westbury @kittaakos thanks for the clarification, I noticed the undo last commit button previously in the application and was wondering if it was removed on purpose (I have seen the command in the builtin).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement issues that are enhancements to current functionality - nice to haves git issues related to git scm issues related to the source control manager
Projects
None yet
Development

No branches or pull requests

3 participants