Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dependencies between the plugins #3645

Closed
azatsarynnyy opened this issue Nov 27, 2018 · 3 comments
Closed

Support dependencies between the plugins #3645

azatsarynnyy opened this issue Nov 27, 2018 · 3 comments
Labels
plug-in system issues related to the plug-in system

Comments

@azatsarynnyy
Copy link
Member

The VSCode plugins may functionally depend on each other by specifying the extensionDependencies attribute in an plugin's manifest file.
It works as the extensionPack attribute - installs the plugin's dependecnies and additionally it guarantees that the plugins are activated in the right order.

As far as I see such dependency mechanism currently isn't supported by Theia. For now there's no other way to ensure the correct work of the VSCode plugins with the functional dependencies on another plugins.

It's needed for eclipse-che/che#11488. I need to load the OpenShift Connector plugin which depends on the K8s plugin.

Dependency between the plugins is declared here.
OpenShift plugin reuses the TreeDataProvider from K8s plugin here.

Additional info will be attached a bit later.

@azatsarynnyy azatsarynnyy added the plug-in system issues related to the plug-in system label Nov 27, 2018
@azatsarynnyy
Copy link
Member Author

The K8s plugin contributes two views with the corresponding TreeDataProviders
k8s

The OpenShift plugin contriutes two views where the Clusters view reuses the TreeDataProvider from the K8s plugin.
os

@azatsarynnyy
Copy link
Member Author

If I manually add both plugin then all views are empty.
all

@azatsarynnyy
Copy link
Member Author

I'm closing it since the OpenShift Connector extension no longer depends on the k8s extension.
Feel free to reopen it if there's a need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plug-in system issues related to the plug-in system
Projects
None yet
Development

No branches or pull requests

1 participant