Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[che-code] Add a GitHub job to check licenses for using libraries for PRs #23363

Open
olexii4 opened this issue Feb 25, 2025 · 2 comments
Open
Assignees
Labels
area/editors kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system. team/B This team is responsible for the Web Terminal, the DevWorkspace Operator and the IDEs.

Comments

@olexii4
Copy link
Contributor

olexii4 commented Feb 25, 2025

Is your enhancement related to a problem? Please describe

It will be useful to have an automatic license check for using libraries for each PR

Describe the solution you'd like

Add a GitHub job to check licenses for using libraries for PRs.

Describe alternatives you've considered

No response

Additional context

No response

@olexii4 olexii4 added the kind/enhancement A feature request - must adhere to the feature request template. label Feb 25, 2025
@olexii4 olexii4 self-assigned this Feb 25, 2025
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Feb 25, 2025
@tolusha
Copy link
Contributor

tolusha commented Feb 25, 2025

Hello @olexii4
Do you have examples such of jub for NodeJs project ?

@RomanNikitenko
Copy link
Member

@olexii4

  • 99 % of the che-code dependencies are VS Code dependencies.
  • I believe che-code dependencies should be as close to upstream as possible - this guarantees stability of the che-code assembly

So, could you clarify please:

  • what's the benefit of adding this Github check?
  • are you going to support that Github check?
  • let's say you are going to change just a version of a lib - but actually - it's VS Code dependency - are you going to contribute such change directly to the upstream? If so - then probably it makes sense to propose adding this Github action to VS Code?

I just want to get a whole picture...
thanks in advance for your answers!

@tolusha tolusha added severity/P2 Has a minor but important impact to the usage or development of the system. area/editors team/B This team is responsible for the Web Terminal, the DevWorkspace Operator and the IDEs. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/editors kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system. team/B This team is responsible for the Web Terminal, the DevWorkspace Operator and the IDEs.
Projects
None yet
Development

No branches or pull requests

4 participants