Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create GH action to check at intervals for the presence of the latest che-server artifacts in Maven Central (and Quay) #18832

Closed
1 of 5 tasks
nickboldt opened this issue Jan 19, 2021 · 2 comments
Assignees
Labels
area/ci CI build and releases, PR testing, & whitelabel/productization issues kind/release Issue dedicated to a release (content, status, related PR, go/nogo/problem discussion, etc.) kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P2 Has a minor but important impact to the usage or development of the system.
Milestone

Comments

@nickboldt
Copy link
Contributor

nickboldt commented Jan 19, 2021

Is your task related to a problem? Please describe.

Recently we had a build process problem where we didn't trap for a maven build failure, and therefore released che-operator even though che-server had not been properly released. The offending script should now be fixed, but the issue remains that we need to have better verifications in place during the release to ensure requirements are met before the next step starts.

Describe the solution you'd like

Until artifacts are found, block starting the che-operator release. We're already doing this \o/

/~https://github.com/eclipse/che-release/blob/master/cico_release.sh#L624-L628

  • new GH action to check at intervals (every 5 mins?) for the presence of latest che-server artifacts in Maven Central. Can use curl + check header for 404 status?

maybe check these 2 artifacts?

eg., can check if pom exists or doesn't exist for a given version:

GH action should run in parallel with the main che-release process (launched by API, but not block downstream phases), since:

  • it can take 2hrs for artifacts to appear in Maven Central, so shouldn't block release as long as mvn build was successful and che-server image exists in Quay
  • we only want it to notify if a problem has occurred (maven artifacts are not needed for Che release, but ARE needed for Hosted Che releases)

Notifications should be:

  • FOR SUCCESS: comment on the current Che Release issue saying that 'Che-server and che-core artifacts are present on Maven Central (with links)'

  • FOR FAILURE / TIMEOUT: post to Eclipse mattermost with news

  • FOR FAILURE / TIMEOUT: email to che-dev@ with news

Describe alternatives you've considered

Additional context

@nickboldt nickboldt added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Jan 19, 2021
@nickboldt nickboldt added area/ci CI build and releases, PR testing, & whitelabel/productization issues area/productization kind/release Issue dedicated to a release (content, status, related PR, go/nogo/problem discussion, etc.) labels Jan 19, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jan 19, 2021
@nickboldt nickboldt changed the title Create GH action to check at intervals for the presence of the latest che-server artifacts in Maven Central and Quay Create GH action to check at intervals for the presence of the latest che-server artifacts in Maven Central (and Quay) Jan 19, 2021
@nickboldt nickboldt added the severity/P2 Has a minor but important impact to the usage or development of the system. label Jan 19, 2021
@nickboldt nickboldt added this to the 7.26 milestone Jan 19, 2021
@nickboldt nickboldt removed the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jan 19, 2021
@nickboldt nickboldt modified the milestones: 7.26, 7.27 Feb 12, 2021
@nickboldt
Copy link
Contributor Author

No news as of Feb 22. Don't yet have a way to send mail, but can definitely use MM notification

@nickboldt nickboldt modified the milestones: 7.27, 7.28 Mar 12, 2021
@nickboldt
Copy link
Contributor Author

no need to do this now, as we will be removing maven artifacts as of 7.29. #18941

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci CI build and releases, PR testing, & whitelabel/productization issues kind/release Issue dedicated to a release (content, status, related PR, go/nogo/problem discussion, etc.) kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

No branches or pull requests

3 participants