Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuring Memory for Che 7 plugins #12783

Closed
tsmaeder opened this issue Feb 27, 2019 · 8 comments
Closed

Configuring Memory for Che 7 plugins #12783

tsmaeder opened this issue Feb 27, 2019 · 8 comments
Labels
kind/enhancement A feature request - must adhere to the feature request template.

Comments

@tsmaeder
Copy link
Contributor

tsmaeder commented Feb 27, 2019

We have some VS Code plugins that require more memory than the default amount for a sidecar. Technically, it is not a problem to change that in the textual workspace configuration. However, there are two things I would propose:

  1. The default memory size for a plugin should be specified in the plugin metadata.
  2. There should be an entry field on the UI item where you enable the plugin for the memory.
@tsmaeder tsmaeder added the kind/enhancement A feature request - must adhere to the feature request template. label Feb 27, 2019
@tsmaeder tsmaeder mentioned this issue Feb 28, 2019
18 tasks
@benoitf
Copy link
Contributor

benoitf commented Feb 28, 2019

related to #11801

@garagatyi
Copy link

Do you suggest removing RAM limit from che-plugin.yaml spec?

@tsmaeder
Copy link
Contributor Author

tsmaeder commented Feb 28, 2019

meta.yaml, che-plugin.yaml, what's the difference anyway? I'm suggesting a user level feature, not an implementation.

@garagatyi
Copy link

The oldest plugin types Che plugin and Che editor are using che-plugin.yaml file hosted outside of the plugin registry to specify all the information about sidecars. Image, ports to expose, env vars, volumes and RAM. These plugins can also have several sidecars in their config, so single RAM limit might not be enough.
But VS Code and Theia plugins don't use this, so can't specify RAM. And they use a single sidecar, so single RAM limit is OK.

My question is whether you want to drop support of RAM limit in che-plugin.yaml or just add support of it to meta.yaml?

@sleshchenko
Copy link
Member

Not sure if there is a plan to merge che-plugin.yaml and meta.yaml files but at least there is discussions and proposals to do it, like the following Mario's comment #12708 (comment)

@garagatyi
Copy link

I faced the situation to configure memory in workspace settings. It's awful UX. So, +1 to implement RAM limit support here ASAP.

@l0rd
Copy link
Contributor

l0rd commented Mar 19, 2019

Will be fixed by #12908 that should be handled by @ibuziuk team in next sprinty

@l0rd l0rd closed this as completed Mar 19, 2019
@l0rd
Copy link
Contributor

l0rd commented Mar 19, 2019

The UI part should be fixed by #11801 (IDE2 team)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

No branches or pull requests

5 participants