Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include TFM in the pre-built report #4798

Open
ViktorHofer opened this issue Dec 6, 2024 · 2 comments
Open

Include TFM in the pre-built report #4798

ViktorHofer opened this issue Dec 6, 2024 · 2 comments
Labels
area-prebuilts Reducing the number of prebuilt packages in the tarball

Comments

@ViktorHofer
Copy link
Member

ViktorHofer commented Dec 6, 2024

The pre-built report that gets generated as part of the repo source-build would benefit from mentioning the TFM that brings the pre-built in. AFAIK there's a file that mentions the projects that bring the packages in and exactly in there the TFM would be extremely useful to mention.

The scenario here are repos that build both the previous and the current TFM in the repo source-build leg. Those need to understand whether pre-builts only affect the repo-source build or the product build. By mentioning the TFM in the report, that validation would become way easier.

The information is already available in the input source for generating the prebuilt reports, the project.assets.json files.

@ViktorHofer ViktorHofer added the area-prebuilts Reducing the number of prebuilt packages in the tarball label Dec 6, 2024
@MichaelSimons
Copy link
Member

[Triage] @ViktorHofer - Do you have a sample use case where this would add value. So often the prebuilt report is just the starting point and you need to open the project.assets.json and/or binlog to gain a true understanding of the prebuilt.

@ViktorHofer
Copy link
Member Author

@nohwnd reached out to me about this as he wasn't sure which pre-builts could be baselined and which ones truly affect the product build.

is just the starting point and you need to open the project.assets.json and/or binlog to gain a true understanding of the prebuilt.

Yes I agree that for more complex scenario you still want / need to look at the project.assets.json files or the actual source. Here I was thinking about the simple cases when $(NetPrevious) introduces a new prebuilt (for whatever reason) which should be baselined.

Note that mentioning the TFM in the error message is general goodness. MSBuild started doing sometime during the previous release and that helped me debug issues quicker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-prebuilts Reducing the number of prebuilt packages in the tarball
Projects
Status: Backlog
Development

No branches or pull requests

2 participants