Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Cecil repo in VMR #3232

Closed
MichaelSimons opened this issue Feb 6, 2023 · 3 comments · Fixed by dotnet/installer#15607
Closed

Build Cecil repo in VMR #3232

MichaelSimons opened this issue Feb 6, 2023 · 3 comments · Fixed by dotnet/installer#15607
Assignees
Labels
area-additional-repos Adding additional contributing repos

Comments

@MichaelSimons
Copy link
Member

With the work to merge linker into the runtime repo, the cecil repo will no longer be a submodule and instead will be a standalone repo. Once the runtime changes flow in to add a dependency on the cecil repo, a source-build cecil project will need to define in order to get it to build.

@tlakollo
Copy link

tlakollo commented Feb 6, 2023

The dotnet cecil project already has source build information being produced and runtime adds the SourceBuild tag into that depedency, is anything else required?

@MichaelSimons
Copy link
Member Author

The dotnet cecil project already has source build information being produced and runtime adds the SourceBuild tag into that depedency, is anything else required?

Yes, there has to be a way in the full product source-build to trigger the cecil repo build. This is done via the repo-projects.

@MichaelSimons
Copy link
Member Author

@mthalman - can you add this project and validate cecil is prebuilt clean? It is dependent on dotnet/installer#15389 flowing it but you could start work now based on that branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-additional-repos Adding additional contributing repos
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants