-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FreeBSD RIDs started to have the OS major version in it #111900
Comments
The behavior of adding MAJORVERSION is correct for non-portable SDKs (e.g., those builds from VMR or using I am not aware of any consumer products that explicitly build against a non-portable SDK, but something like runtime/src/libraries/Microsoft.NETCore.Platforms/src/runtime.json Lines 1714 to 1718 in 7e82ad9
|
AFAIK the Linux binaries published by MS use the portable build e.g. they are not specific to particular OS version. |
I think the question was more like, that when using, ex.
But, under FreeBSD 14, using So maybe, the question was, should (or more how) |
The portable version should be used instead of a non-portable version where possible: https://learn.microsoft.com/en-us/dotnet/core/rid-catalog#using-rids The portable SDK will not understand Non-portable builds of the SDK should automagically put the non-portable RID into the RID graph so the SDK will know how to use the non-portable RID |
In ports/packages we have non-portable builds, right (from VMR) - so that's the one that end-user are using
So looks like this is not the case or we miss something? |
You may need to use |
@arrowd That should do the trick for building under different FreeBSD releases - or patch this into proper number based on build system then, right? |
I haven't built PowerShell myself, and honestly I still didn't get it - what should be patched in the PowerShell project files to make it work? |
I did my try on pwsh build using one of the wip ports we had, and had success, but hit one thing on the road.
This must be something wrong set inside RIDs in SDK ?
|
@sec |
edit: nope, it's not fixed in 9.0.2, SDK 9.0.103, but that's what compiled when using VMR build - looks like this should be fixed in 9.0.200 ... |
The .NET 9 package on FreeBSD installs the following file:
The same file installed by the .NET 8 package is named differently:
Notice the added OS major version suffix (
freebsd.14-x64
vs.freebsd-x64
).I'm not sure which variant is more corrent, but FreeBSD doesn't indeed guarantee ABI compatibility between major releases. So, appending the
.14
part feels right.However, it is now unclear what consumer projects should now do wrt. to RID being used. For example, what shoud PowerShell put in there /~https://github.com/PowerShell/PowerShell/blob/master/src/powershell-unix/powershell-unix.csproj#L12 ?
The text was updated successfully, but these errors were encountered: