Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link weakly to NewsstandKit #18606

Closed
rolfbjarne opened this issue Aug 1, 2023 · 0 comments · Fixed by #18621
Closed

Link weakly to NewsstandKit #18606

rolfbjarne opened this issue Aug 1, 2023 · 0 comments · Fixed by #18621
Assignees
@rolfbjarne
Labels
bug If an issue is a bug or a pull request a bug fix high-priority This is a high-priority issue or pull request
Milestone
Future

Comments

@rolfbjarne
Copy link
Member

iOS 17 seems to completely remove the NewsstandKit framework.

This is problematic for apps that happen to link with the NewsstandKit framework (they crash at launch).

Ref: dotnet/maui#16316

We should look into always linking weakly with NewsstandKit (in existing stable release for .NET 7), so that existing apps won't crash when end users upgrade to iOS 17.
@rolfbjarne rolfbjarne added bug If an issue is a bug or a pull request a bug fix high-priority This is a high-priority issue or pull request labels Aug 1, 2023
@rolfbjarne rolfbjarne added this to the Future milestone Aug 1, 2023
@rolfbjarne rolfbjarne self-assigned this Aug 1, 2023
rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this issue Aug 2, 2023
@rolfbjarne
[tools] Always link weakly with NewsstandKit. Fixes dotnet#18606.
61633f2 
It seems that Apple will completely remove the NewsstandKit framework from iOS 17.

This poses a problem for existing apps that link with NewsstandKit: they will
crash at launch.

Solve this by always linking weakly with the NewsstandKit framework; this way
any apps that link with it will keep working if the framework ends up being
removed by Apple.

Fixes dotnet#18606.
@rolfbjarne rolfbjarne mentioned this issue Aug 2, 2023
Merged
rolfbjarne added a commit that referenced this issue Aug 3, 2023
@rolfbjarne
[tools] Always link weakly with NewsstandKit. Fixes #18606. (#18621)
82a5174 
It seems that Apple will completely remove the NewsstandKit framework from iOS 17.

This poses a problem for existing apps that link with NewsstandKit: they will
crash at launch.

Solve this by always linking weakly with the NewsstandKit framework; this way
any apps that link with it will keep working if the framework ends up being
removed by Apple.

Fixes #18606.
Fixes dotnet/maui#16316.
vs-mobiletools-engineering-service2 pushed a commit to vs-mobiletools-engineering-service2/xamarin-macios that referenced this issue Aug 3, 2023
@rolfbjarne
[tools] Always link weakly with NewsstandKit. Fixes dotnet#18606.
ad18030 
It seems that Apple will completely remove the NewsstandKit framework from iOS 17.

This poses a problem for existing apps that link with NewsstandKit: they will
crash at launch.

Solve this by always linking weakly with the NewsstandKit framework; this way
any apps that link with it will keep working if the framework ends up being
removed by Apple.

Fixes dotnet#18606.
Merged
vs-mobiletools-engineering-service2 pushed a commit to vs-mobiletools-engineering-service2/xamarin-macios that referenced this issue Aug 3, 2023
@rolfbjarne
[tools] Always link weakly with NewsstandKit. Fixes dotnet#18606.
d3c08ff 
It seems that Apple will completely remove the NewsstandKit framework from iOS 17.

This poses a problem for existing apps that link with NewsstandKit: they will
crash at launch.

Solve this by always linking weakly with the NewsstandKit framework; this way
any apps that link with it will keep working if the framework ends up being
removed by Apple.

Fixes dotnet#18606.
Merged
rolfbjarne pushed a commit that referenced this issue Aug 4, 2023
@vs-mobiletools-engineering-service2
[release/7.0.3xx] [tools] Always link weakly with NewsstandKit. Fixes #…
1cd12c4 
…18606. (#18624)

It seems that Apple will completely remove the NewsstandKit framework from iOS 17.

This poses a problem for existing apps that link with NewsstandKit: they will
crash at launch.

Solve this by always linking weakly with the NewsstandKit framework; this way
any apps that link with it will keep working if the framework ends up being
removed by Apple.

Fixes #18606.
Fixes dotnet/maui#16316.

Backport of #18621
rolfbjarne pushed a commit that referenced this issue Aug 7, 2023
@vs-mobiletools-engineering-service2
[xcode14.3] [tools] Always link weakly with NewsstandKit. Fixes #18606.…
ee979e3 
… (#18625)

It seems that Apple will completely remove the NewsstandKit framework from iOS 17.

This poses a problem for existing apps that link with NewsstandKit: they will
crash at launch.

Solve this by always linking weakly with the NewsstandKit framework; this way
any apps that link with it will keep working if the framework ends up being
removed by Apple.

Fixes #18606.
Fixes dotnet/maui#16316.

Backport of #18621
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rolfbjarne rolfbjarne

Labels
bug If an issue is a bug or a pull request a bug fix high-priority This is a high-priority issue or pull request
Projects
None yet
Milestone
Future
Development

Successfully merging a pull request may close this issue.

[tools] Always link weakly with NewsstandKit. Fixes #18606. rolfbjarne/xamarin-macios
1 participant
@rolfbjarne