Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

.NET 8 PR [Merge on 11/14] #972

Merged
merged 15 commits into from
Dec 12, 2023
Merged

.NET 8 PR [Merge on 11/14] #972

merged 15 commits into from
Dec 12, 2023

Conversation

jamesmontemagno
Copy link
Contributor

No description provided.

@jamesmontemagno jamesmontemagno changed the title .NET 8 PR .NET 8 PR [Merge on 11/14] Nov 2, 2023
@@ -1,7 +1,11 @@
<Project>
<PropertyGroup>
<ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
<TargetFramework>net7.0</TargetFramework>
<TargetFramework>net8.0</TargetFramework>
<AspNetVersion>8.0.0-rc.2.23480.2</AspNetVersion>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These version numbers can now be 8.0.0 now, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup yup!

Comment on lines 58 to 60
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.6.3" />
<PackageVersion Include="xunit" Version="2.4.2" />
<PackageVersion Include="xunit.runner.visualstudio" Version="2.4.5">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could have these test reference updated also

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will create another issue for this.... just to verify any changes

@WeihanLi
Copy link

WeihanLi commented Dec 8, 2023

The default port changed from 80 to 8080 for containers, see details here: https://learn.microsoft.com/en-us/dotnet/core/compatibility/containers/8.0/aspnet-port

while it seems we do not have any changes about that, we may need some changes to keep the container working

@jamesmontemagno
Copy link
Contributor Author

@WeihanLi fixed up ;) good catch

@jamesmontemagno jamesmontemagno merged commit 4172b47 into main Dec 12, 2023
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants