You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While looking into upgrading our largest app to ORM 3 (now unblocked since doctrine-extensions/DoctrineExtensions#2808 (comment)) I stumbled across the breaking change for QueryBuilder::setParameters that now only accepts ArrayCollection<int, Parameter> and no array anymore:
Feature Request
While looking into upgrading our largest app to ORM 3 (now unblocked since doctrine-extensions/DoctrineExtensions#2808 (comment)) I stumbled across the breaking change for
QueryBuilder::setParameters
that now only acceptsArrayCollection<int, Parameter>
and noarray
anymore:orm/src/QueryBuilder.php
Line 474 in 9d4f54b
However I noticed that
AbstractQuery
still acceptsarray
as before:orm/src/AbstractQuery.php
Line 303 in 9d4f54b
So I was wondering if there is a reason that those 2 are inconsistent and if we maybe could also allow
array
again onQueryBuilder::setParameters
?Otherwise I guess I would have to update the 100+ places to use
ArrayCollection
+Parameter
instances or look into writing a rector rule for it 🙈Summary
Allow
array
again onQueryBuilder::setParameters
to ease upgrade from ORM 2?The text was updated successfully, but these errors were encountered: