Summary of the 20 issues in Herbsleb's 2014 FSE paper.

[dichen001]

All(20) the pull requests they studied.

1. Don't barf on the datetime2 data type when connecting to MS SQL 2008 jruby/activerecord-jdbc-adapter#233
2. ui: print to STDERR (play nice with UNIX pipes) guard/guard#156
3. Fix for session_start() which doesn't check if the session has already started symfony/symfony#5248
4. support for referencing view in ViewState by path emberjs/ember.js#365
5. Personal snipepts support added gitlabhq/gitlabhq#3351
6. Example using TroopJS tastejs/todomvc#120
7. Update phpDoc to use Fully Qualified Class Name laravel/framework#720
8. Made QS only change text to URLs if there's a valid TLD on the end quicksilver/Quicksilver#219
9. [#752] Support discarding cookies on a particular path, domain and ensure Session/Flash cookies use this playframework/playframework#469
10. Add support for WebP file format AcademySoftwareFoundation/OpenImageIO#82
11. Refactor Panel, Layout, Expo and Scale to handle various panel configurations linuxmint/cinnamon#1003
12. UI changes and modernizr.js for the contacts app. owncloud-archive/apps#1
13. Once jashkenas/backbone#697
14. accept file-like objects in np.load memmap mode numpy/numpy#3306
15. Allow starting Appium.app from commandline without global install of nodejs appium/appium#793
16. Unencapsulate css global reset activeadmin/activeadmin#1952
17. stbt.py: Support multiple lirc devices connected to the same host stb-tester/stb-tester#9
18. xe manpages xapi-project/xen-api#957
19. crontabs and common paths bundle cfengine/design-center#14
20. add smush.py and update pngnq Homebrew/legacy-homebrew#3403

Categories they summarized.

Issues around code contribution

• Disapprove of the problem being solved
  • Project appropriateness
  • (2,7,14,15,16,19,20)
  • Value Proposition Request
  • (core ask for use case or test case: 1,2,3,4,13,14,20)
• Disapprove of the solusion.
• Question solution approach.
  - (2,4,8,9,10,11,17,18,20)
• Suggest alternative solutions
  - (2,7,8,9,11,15,19)
• Advertise Own Solution
  - （implement their own and adervertise: 2,3,13,15）
• Disagreement among the core (NEED TO REVIEW)
• (core disaggre each other 2,3,6,8,10,11,12)
• (defer to senior core. 2,3)
• (senior admonish other core 2,3)

Methods of Influencing the decision process

• Audience pressure
  • Community support
    • (indicating support: 1,2,3,5,7,9,13,14,16,19 [2,5,13,16 are +1 or emoji])
    • (commenting 1,7,|| 2,3,14,19)
  • Project & company support
    • (cited own projectsor companies: 3,6,13,14,16,18)
• Alerting the core
  • (alert: developer @ core- 2,3,13,14,16,18,19)
  • (start review: submitter/core @ core- 13,16)
  • (continue review: core @ submitter: 14)
  • (solicit feedback: core @ core: 2,3,18)
  • Submitter asks core about evaluation status.
    • 18 days(P13), 2 months(P16) after inactivity.

Outcomes for the proposed code contributions

• Rejection and meeting technical goals
  • (core meet the goal: 3,7,13,15)
• Contribution outcomes
  • (audience influenced outcome: 1)
  • (accepted or implemented by core later 2,3,5,6,7,9,13,16,18,19)
• Future contributions advertised
  • (accepted: 2,4,7,11,18,19)
  • (rejected: 4,7,11)

Submitters prior experience

• Core thanking new submitters
  • (thanks 2,5,6,11,12,13,18,19)
  • (apology for late response, 6,10,12,13,18,20)
• Alternative Solutions for new submitters
  • (7,8,9,11,15 || 2,3)

[dichen001]

Something Herbsleb missed, while MT workers found them.

Support

They don't indicate (17), which also shows support in the comment.

drothlis commented on Apr 18, 2013
This is great news!

Suggest alternative solutions

They don't indicate (16) and (21), which also has someone proposing alternate solutions.

(16)

smidwap commented on Jul 9, 2013
What might be better is to place active_admin.css in a sub-directory, so it could be active_admin/active_admin.css. Then developers could be urged to change require_tree . to require_directory .

(20)

MikeMcQuaid commented on Nov 29, 2010
No, I think you can just push -f after squashing.

Disapprove of the solution. *

The missed (3) which did question the solution approach.
(Need to check whether their classification is correct.)

ghost commented on Aug 14, 2012
I would suggest if we look deeper here, there is probably another way of doing whatever the reporter is trying to do. For one, if using HttpFoundation, there should be no reason for the SF2 session code to be hit at all. If someone is running Symfony2 fullstack framework inside wordpress, it's seems possibly the wrong approach to solve the problem.

Outcome - Accepted

They missed (10), which is merged in fact, even though we can only see the 'closed' label. But core said 'merged'. Check the contribution page for this submitter, we can find his commits for this PR has been merged.

Need to pay attention to this one. Core helped submitter merged. While API says closed without a 'merged' label

Commits on Jun 13, 2011
@matekm @lgritz
Added support for webp format. For now plugin reads the whole content… …
matekm committed with lgritz on May 21, 2011

[ilya-palachev]

@dichen001 , thanks for good summarization! Just for clarification, which "MT workers" do you mean in the last comment?