GL version being reported is wrong?

[Fancy2209]

The readme claims 1.5, but OpenGX itself reports 1.1, is this intended?
/~https://github.com/devkitPro/opengx/blob/master/src/getters.c#L58

[mardy]

Hi! No, it's indeed a bug! I already have a branch that fixes this, along with other changes. I'll submit it in a few days.

[Fancy2209]

Hi! No, it's indeed a bug! I already have a branch that fixes this, along with other changes. I'll submit it in a few days.

Doesn't that bump OpenGX to GL2 though? Or did I misread the diff
Btw really nice to see Shaders on the Wii!

[mardy]

Doesn't that bump OpenGX to GL2 though? Or did I misread the diff Btw really nice to see Shaders on the Wii!

The code there does

return ogx_get_proc_address("glUseProgram") ? "2.0" : "1.5";

that is, it will return "2.0" only if ogx_get_proc_address() manages to resolve the "glUseProgram" name into a function pointer. If you look at the new code in functions.c, you'll see that this succeeds only if the symbol _ogx_shader_functions which is weakly defined as an empty array at the top of this file will be overshadowed by the same symbol defined in shader_functions.h, which is included in shader.c only. Effectively this means that the real (full) symbol will only be used if the client directly invokes any function defined in shader.c -- and the client will do that only if needs to use the OpenGL 2.0+ functionalities.

[Fancy2209]

Doesn't that bump OpenGX to GL2 though? Or did I misread the diff Btw really nice to see Shaders on the Wii!

The code there does

return ogx_get_proc_address("glUseProgram") ? "2.0" : "1.5";

that is, it will return "2.0" only if ogx_get_proc_address() manages to resolve the "glUseProgram" name into a function pointer. If you look at the new code in functions.c, you'll see that this succeeds only if the symbol _ogx_shader_functions which is weakly defined as an empty array at the top of this file will be overshadowed by the same symbol defined in shader_functions.h, which is included in shader.c only. Effectively this means that the real (full) symbol will only be used if the client directly invokes any function defined in shader.c -- and the client will do that only if needs to use the OpenGL 2.0+ functionalities.

Ooohhh I see, that's really smart, I had no idea you could do things like that, I saw those parts of the code but didn't understand how proc_adress would return null, good to know, thanks.