Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible to publish a crate using this to crates.io #17

Open
dr-bonez opened this issue Jul 29, 2020 · 3 comments
Open

Impossible to publish a crate using this to crates.io #17

dr-bonez opened this issue Jul 29, 2020 · 3 comments

Comments

@dr-bonez
Copy link

Since this package requires having the ptx crate as a path dependency, it is impossible to publish a dependent crate to crates.io because of rust-lang/rfcs#2224.

It would be good if you could specify a crate from crates.io in your build.rs instead of a path.

@denzp
Copy link
Owner

denzp commented Aug 1, 2020

Hi, thanks for checking out the project!

Could you please explain a little in details your use case and where is that path dependency?

Technically, there is no such requirement coming from this crate. It should be possible to create either a binary or library crate that contains both device and host code. With this approach, there is no need to depend on any other local crates via a path. As a bonus, you can still publish device-only crates, that would not even have a dependency on ptx-builder and would be treated any other crate on crates.io.

@dr-bonez
Copy link
Author

dr-bonez commented Aug 5, 2020

The crate being compiled by the builder during build.rs is referred to by path: https://docs.rs/ptx-builder/0.5.3/ptx_builder/builder/struct.Builder.html
Since this folder must include a Cargo.toml, it cannot be included in the source bundle that is published to crates.io.

@dr-bonez
Copy link
Author

dr-bonez commented Aug 5, 2020

For context, the crate I'm trying to publish is /~https://github.com/dr-bonez/tor-v3-vanity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants