Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intransparent score assignment when concatenating documents using JoinDocuments #2558

Closed
MichelBartels opened this issue May 16, 2022 · 2 comments
Closed

Intransparent score assignment when concatenating documents using JoinDocuments #2558

MichelBartels opened this issue May 16, 2022 · 2 comments
Assignees
@MichelBartels
Labels
topic:predictions format of predictions, score, probability ... type:documentation Improvements on the docs

Comments

@MichelBartels
Copy link
Contributor

When specifying concatenate as the join_mode in the JoinDocuments node, the scores of each document are set to the scores by the last retriever in the list of inputs that contains the document.
This is caused by this line and can be confusing. This behaviour should probably either be documented or changed.
@MichelBartels MichelBartels changed the title Intransparent scores when concatenating documents using JoinDocuments Intransparent score assignment when concatenating documents using JoinDocuments May 16, 2022
@ZanSara
Copy link
Contributor

ZanSara commented May 16, 2022

Hey @MichelBartels, I believe the first thing to do is to document this behavior. Would you mind doing so in a quick PR? We will then keep this issue open for a future fix, if you wish.

Thank you! 😊

@ZanSara ZanSara added action:needs documentation type:documentation Improvements on the docs topic:predictions format of predictions, score, probability ... labels May 16, 2022
@MichelBartels MichelBartels mentioned this issue May 16, 2022
Merged
5 tasks
@ZanSara
Copy link
Contributor

ZanSara commented May 16, 2022

Fixed in #2561

@ZanSara ZanSara closed this as completed May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MichelBartels MichelBartels

Labels
topic:predictions format of predictions, score, probability ... type:documentation Improvements on the docs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ZanSara @MichelBartels