Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change or remove resolveAttributes #9

Open
de-jcup opened this issue Jun 19, 2019 · 1 comment
Open

Change or remove resolveAttributes #9

de-jcup opened this issue Jun 19, 2019 · 1 comment

Comments

@de-jcup
Copy link
Owner

de-jcup commented Jun 19, 2019

Currently the attributes are fetched only one time, than cached.

But they cannot be reset by client in any way...

So either remove the method at all (client +server) or provide a reset method as well
see also de-jcup/eclipse-asciidoctor-editor#229
@de-jcup
Copy link
Owner Author

de-jcup commented Jun 19, 2019 •
edited
Loading

The caching is a bad taste here - should be done by clients not on server side. A client will assume this is always new resolved! So a reset or a caching makes no sense here!

So at least remove caching

@de-jcup de-jcup changed the title Either remove resolveAttributes, or provide a reset method Change or remove resolveAttributes Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@de-jcup