Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extractors should not use git ls-files #384

Open
mih opened this issue Jul 19, 2023 · 1 comment
Open

Extractors should not use git ls-files #384

mih opened this issue Jul 19, 2023 · 1 comment

Comments

@mih
Copy link
Member

mih commented Jul 19, 2023

http://docs.datalad.org/projects/metalad/en/latest/user_guide/writing-extractors.html recommends using git ls-file under Tips.

I think this should be replaced with git ls-tree. I cannot come up with a use case where an extractor would want to process uncommitted work tree content. Recommending ls-file communicates something that likely leads to faulty implementations.

@christian-monch
Copy link
Collaborator

Good point, thanks. Will fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants